Bugzilla – Attachment 4936 Details for
Bug 6699
Add not-empty check for warnings from load_sql in Installer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
patch.txt (text/plain), 1.02 KB, created by
Marcel de Rooy
on 2011-08-10 13:39:17 UTC
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2011-08-10 13:39:17 UTC
Size:
1.02 KB
patch
obsolete
>From 029043856e9012af24cf359224bcc31175541861 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 10 Aug 2011 15:23:07 +0200 >Subject: [PATCH] 6699 Add not-empty check for warnings from load_sql in Installer >Content-Type: text/plain; charset="utf-8" > >Eliminates fake warnings "Something is wrong on line 530". >--- > C4/Installer.pm | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/C4/Installer.pm b/C4/Installer.pm >index 80ef627..4831969 100644 >--- a/C4/Installer.pm >+++ b/C4/Installer.pm >@@ -526,8 +526,10 @@ sub load_sql { > # report the import a failure although it really succeded -fbcit > } > # errors thrown while loading installer data should be logged >- warn "C4::Installer::load_sql returned the following errors while attempting to load $filename:\n"; >- warn $error; >+ if($error) { >+ warn "C4::Installer::load_sql returned the following errors while attempting to load $filename:\n"; >+ warn $error; >+ } > return $error; > } > >-- >1.6.0.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6699
:
4936
|
6194