Attachment 49381 Details for Bug 16060 – [PASSED QA] Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found

[patch] [PASSED QA] Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found

PASSED-QA-Bug-16060---Add-Font-Awesome-icon-to-Z39.patch (text/plain), 2.36 KB, created by Katrin Fischer on 2016-03-21 07:08:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-03-21 07:08:55 UTC

Size: 2.36 KB

patch

obsolete

>From d5cb1f23c1c7f9d23905436de8557ac8bb72fbf8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 10 Mar 2016 09:19:14 -0500
>Subject: [PATCH] [PASSED QA] Bug 16060 - Add Font Awesome icon to Z39.50
> search button when no results are found
>
>When a staff client catalog search returns no results, a Z39.50/SRU
>search button is shown. This patch adds a Font Awesome icon to that
>button.
>
>Also changed: A stray extra double quote has been removed. The onclick
>attribute has been removed from the search button in favor of an event
>already defined.
>
>To test, apply the patch and perform a search in the staff client
>catalog which will return no results.
>
>- Confirm that the Z39.50/SRU button looks correct and works correctly.
>- Validate the HTML of the page and confirm that no unexpected errors
>  are returned.
>
>NOTE: Pretty!
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 68658fe..0e77646 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -361,7 +361,7 @@ var holdForPatron = function () {
>                         </ul>
>                     </div>
>                 [% ELSE %]
>-                    <div id="placeholdc" class="btn-group"><a class="btn btn-mini placehold" href="#"><i class="fa fa-sticky-note-o""></i> Place hold</a></div>
>+                    <div id="placeholdc" class="btn-group"><a class="btn btn-mini placehold" href="#"><i class="fa fa-sticky-note-o"></i> Place hold</a></div>
>                 [% END %]
>                 [% END %]
> 
>@@ -371,7 +371,7 @@ var holdForPatron = function () {
>     [% ELSE %]
>         <div id="searchheader">
> 			<form method="post" name="fz3950" class="fz3950bigrpad">
>-				<span id="z3950searchc"><input type="button" id="z3950search" value="Z39.50 Search" onclick="PopupZ3950(); return false;" /></span>
>+                <button class="btn" type="button" id="z3950submit"><i class="fa fa-search"></i> Z39.50/SRU search</button>
> 			</form>
>             <h3>No results found</h3>
>         [% IF ( searchdesc ) %]
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16060: 49095 | 49366 | 49381