Attachment 4939 Details for Bug 6700 – Signed patch of Chris (test for XXX version)

[patch] Signed patch of Chris (test for XXX version)

patch.txt (text/plain), 2.26 KB, created by Marcel de Rooy on 2011-08-10 14:36:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2011-08-10 14:36:21 UTC

Size: 2.26 KB

patch

obsolete

>From 60b3c451b04464d34bd0aedda47831e2049a0713 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chris@bigballofwax.co.nz>
>Date: Mon, 8 Aug 2011 23:45:00 +0200
>Subject: [PATCH] [SIGNED-OFF] Test to check for XXX in kohaversion.pl or updatedatabase.pl
>Content-Type: text/plain; charset="utf-8"
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Works as advertised.
>---
> t/00-checkdatabase-version.t |   53 ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 53 insertions(+), 0 deletions(-)
> create mode 100644 t/00-checkdatabase-version.t
>
>diff --git a/t/00-checkdatabase-version.t b/t/00-checkdatabase-version.t
>new file mode 100644
>index 0000000..cfd76fb
>--- /dev/null
>+++ b/t/00-checkdatabase-version.t
>@@ -0,0 +1,53 @@
>+# Copyright 2010 Chris Cormack
>+#
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it under the
>+# terms of the GNU General Public License as published by the Free Software
>+# Foundation; either version 2 of the License, or (at your option) any later
>+# version.
>+#
>+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
>+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
>+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License along
>+# with Koha; if not, write to the Free Software Foundation, Inc.,
>+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>+
>+use strict;
>+use warnings;
>+
>+use Test::More;
>+use File::Spec;
>+use File::Find;
>+use IO::File;
>+
>+my @files =('kohaversion.pl','installer/data/mysql/updatedatabase.pl');
>+
>+foreach my $file (@files){
>+    next unless -f $file;
>+    my @name_parts = File::Spec->splitpath($file);
>+    my %dirs = map { $_ => 1 } File::Spec->splitdir($name_parts[1]);
>+    next if exists $dirs{'.git'};
>+
>+    my $fh = IO::File->new($file, 'r');
>+    my $xxx_found = 0;
>+    my $line = 0;
>+    while (<$fh>) {
>+       $line++;
>+       if (/XXX/i) {
>+           $xxx_found = 1;
>+          last;
>+       }
>+     }
>+     close $fh;
>+     if ($xxx_found) {
>+         fail("$file has no XXX in it");
>+        diag("XXX found in line $line");
>+     } else {
>+        pass("$file has no XXX in it");
>+    }
>+}
>+
>+done_testing();
>-- 
>1.6.0.6
>

Actions: View | Diff | Splinter Review

Attachments on bug 6700: 4939 | 4942 | 6183 | 6868 | 6869