Bugzilla – Attachment 49424 Details for
Bug 15866
No warning when deleting a rotating collection using the toolbar button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15866: Add confirm message for deleting rotating collection from toolbar
PASSED-QA-Bug-15866-Add-confirm-message-for-deleti.patch (text/plain), 2.79 KB, created by
Katrin Fischer
on 2016-03-23 06:26:17 UTC
(
hide
)
Description:
[PASSED QA] Bug 15866: Add confirm message for deleting rotating collection from toolbar
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-23 06:26:17 UTC
Size:
2.79 KB
patch
obsolete
>From 743e7763bbb7885e6d685f80978d7966029d66eb Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Sun, 20 Mar 2016 23:24:18 +0000 >Subject: [PATCH] [PASSED QA] Bug 15866: Add confirm message for deleting > rotating collection from toolbar >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1) Go to Tools -> Rotating Collections >2) Click on any rotating collection ('Add or remove items' from drop down menu) >3) Click 'Delete' from toolbar. Validate you are now asked to confirm your deletion. Check that cancel works, then check that confirm works. > >Sponsored-by: Catalyst IT > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >I've added the word 'rotating' before collection, to make >it clear for translators what is meant here. >--- > .../prog/en/includes/rotating-collections-toolbar.inc | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/rotating-collections-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/rotating-collections-toolbar.inc >index 8abdbe9..5ff76fb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/rotating-collections-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/rotating-collections-toolbar.inc >@@ -1,3 +1,17 @@ >+<script type="text/javascript"> >+ $(document).ready(function(){ >+ $(".confirmdelete").click(function(){ >+ $(this).parents('tr').addClass("warn"); >+ if(confirm(_("Are you sure you want to delete this rotating collection?"))){ >+ return true; >+ } else { >+ $(this).parents('tr').removeClass("warn"); >+ return false; >+ } >+ }); >+}); >+</script> >+ > <div id="toolbar" class="btn-toolbar"> > <div class="btn-group"> > <a class="btn btn-small" href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=new"><i class="fa fa-plus"></i> New collection</a> >@@ -11,7 +25,7 @@ > <a class="btn btn-small" href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=edit&colId=[% colId %]"><i class="fa fa-pencil"></i> Edit</a> > </div> > <div class="btn-group"> >- <a class="btn btn-small" href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=delete&colId=[% colId %]"><i class="fa fa-remove"></i> Delete</a> >+ <a class="btn btn-small confirmdelete" href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=delete&colId=[% colId %]"><i class="fa fa-remove"></i> Delete</a> > </div> > [% END %] >- </div> >\ No newline at end of file >+ </div> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15866
:
49362
|
49382
| 49424