Attachment 49427 Details for Bug 16131 – Bug 16131: Messages for branch transfers show with bullet points

[patch] Bug 16131: Messages for branch transfers show with bullet points

Bug-16131-Messages-for-branch-transfers-show-with-.patch (text/plain), 4.01 KB, created by Marc Véron on 2016-03-23 08:19:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-03-23 08:19:30 UTC

Size: 4.01 KB

patch

obsolete

>From 1d016b58c5e02f9212f200eefcb8a3ee1c5444c9 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Wed, 23 Mar 2016 03:44:53 +0000
>Subject: [PATCH] Bug 16131: Messages for branch transfers show with bullet
> points
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patches removes the list code from the messages
>
>To test:
>1) Attempt to transfer an item to its home library. Confirm no bullet point in message
>2) Check out an item to a user. Attempt to transfer the same item. Confirm no bullet point in message
>3) Set syspref BranchTransferLimitsType to Enforce for item types. Go to Admin -> Library transfer limits and select a library (Library B) other than your home library (Library A). Uncheck all options. Go back to branch transfers and attempt to transfer an item from Library A to Library B. Confirm no bullet point in message.
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> .../prog/en/modules/circ/branchtransfers.tt             |   15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>index e2916d9..a445c25 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>@@ -104,16 +104,15 @@
> 
>                      [% IF ( errmsgloop ) %]
>                         <div class="dialog message">
>-                            <ul>
>                              [% FOREACH errmsgloo IN errmsgloop %]
>                               [% IF ( errmsgloo.errbadcode ) %]
>-                                  <li>No Item with barcode: [% errmsgloo.msg %]</li>
>+                                  No item with barcode: [% errmsgloo.msg %]
>                               [% END %]
>                               [% IF ( errmsgloo.errispermanent ) %]
>-                                  <li>Please return item to home library: [% errmsgloo.msg %]</li>
>+                                  Please return item to home library: [% errmsgloo.msg %]
>                               [% END %]
>                               [% IF ( errmsgloo.errnotallowed ) %]
>-                                  <li>Transfer is not allowed for:
>+                                  Transfer is not allowed for:
>                                       <ol>
>                                           [% IF ( Koha.Preference('BranchTransferLimitsType') == 'itemtype' ) %]
>                                               <li>Item type: <b>[% ItemTypes.GetDescription( errmsgloo.code ) %]</b></li>
>@@ -122,18 +121,16 @@
>                                           [% END %]
>                                           <li>Destination library: <b>[% errmsgloo.tbr %]</b></li>
>                                       </ol>
>-                                  </li>
>                               [% END %]
>                               [% IF ( errmsgloo.errdesteqholding ) %]
>-                                  <li>Item is already at destination library.</li>
>+                                  Item is already at destination library.
>                               [% END %]
>                               [% IF ( errmsgloo.errwasreturned ) %]
>-                                  <li>Item was on loan to <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% errmsgloo.borrowernumber %]">
>+                                  Item was on loan to <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% errmsgloo.borrowernumber %]">
>                                   [% errmsgloo.firstname %] [% errmsgloo.surname %]
>-                                  ([% errmsgloo.cardnumber %])</a> and has been returned.</li>
>+                                  ([% errmsgloo.cardnumber %])</a> and has been returned.
>                               [% END %]
>                           [% END %]
>-                          </ul>
>                             </div>
>                         [% END %]
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16131: 49422 | 49427