Attachment 49440 Details for Bug 7594 – Bug 7594: Google Cover Javascript contains hardcoded CSS style

[patch] Bug 7594: Google Cover Javascript contains hardcoded CSS style

Bug-7594-Google-Cover-Javascript-contains-hardcode.patch (text/plain), 1.95 KB, created by Tomás Cohen Arazi (tcohen) on 2016-03-23 14:42:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-03-23 14:42:31 UTC

Size: 1.95 KB

patch

obsolete

>From 06a64ca45c23df55e7882e92b16a287870f31d17 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 22 Mar 2016 08:07:44 -0400
>Subject: [PATCH] Bug 7594: Google Cover Javascript contains hardcoded CSS
> style
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The JavaScript which handles the display of Google book cover images
>includes a hard-coded "style" attribute. It may have been relevant to
>the design of the old prog template, but it doesn't seem to have any use
>in the Bootstrap one. This patch removes it.
>
>I have replaced the style attribute with a class in case someone needs
>a hook for some custom CSS.
>
>To test, apply the patch, enable the GoogleJackets system preference,
>and clear your browser cache if necessary.
>
>- Search for a title in the OPAC which has a Google book cover image
>  associated with it.
>- View the detail page for that title. Confirm that the "Google Preview"
>  link underneath the cover image looks correct.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js b/koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js
>index 49566ed..85592cd 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js
>@@ -55,7 +55,7 @@ KOHA.Google = {
>                      var re = /^gbs-thumbnail-preview/;
>                      if ( re.exec($(this).attr("id")) ) {
>                          $(this).append(
>-                             '<div style="margin-bottom:5px; margin-top:-5px;font-size:9px">' +
>+                             '<div class="google-books-preview">' +
>                              '<a '+target+'href="' +
>                              book.info_url +
>                              '"><img src="' +
>-- 
>2.7.3

Actions: View | Diff | Splinter Review

Attachments on bug 7594: 49413 | 49430 | 49440