Bugzilla – Attachment 49456 Details for
Bug 16136
Koha::Patron contains 'return undef' and fails critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16136: Koha::Patron contains 'return undef' and fails critic tests
Bug-16136-KohaPatron-contains-return-undef-and-fai.patch (text/plain), 1.12 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-03-23 18:03:14 UTC
(
hide
)
Description:
Bug 16136: Koha::Patron contains 'return undef' and fails critic tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-03-23 18:03:14 UTC
Size:
1.12 KB
patch
obsolete
>From 3689bf9200ef2c0eb25f0d6302a045675ae19fa6 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >Date: Wed, 23 Mar 2016 14:57:41 -0300 >Subject: [PATCH] Bug 16136: Koha::Patron contains 'return undef' and fails > critic tests > >This patch fixes this issue. > >To test: >- Run > $ TEST_QA=1 prove t/00-testcritic.t >=> FAIL: Koha::Patron makes the tests fail. >- Apply the patch >- Run > $ TEST_QA=1 prove t/00-testcritic.t >=> SUCCESS: tests PASS >- Sign off > >Regards >--- > Koha/Patron.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index 684f274..68cb822 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -45,7 +45,7 @@ Returns a Koha::Patron object for this patron's guarantor > sub guarantor { > my ( $self ) = @_; > >- return undef unless $self->guarantorid(); >+ return unless $self->guarantorid(); > > return Koha::Patrons->find( $self->guarantorid() ); > } >@@ -79,7 +79,7 @@ sub siblings { > > my $guarantor = $self->guarantor; > >- return undef unless $guarantor; >+ return unless $guarantor; > > return Koha::Patrons->search( > { >-- >2.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16136
:
49456
|
49458