Attachment 49472 Details for Bug 15793 – Bug 15793 - UX of circulation patron search with long lists of returned borrowers

[patch] Bug 15793 - UX of circulation patron search with long lists of returned borrowers

Bug-15793---UX-of-circulation-patron-search-with-l.patch (text/plain), 3.46 KB, created by Aleisha Amohia on 2016-03-23 21:55:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2016-03-23 21:55:51 UTC

Size: 3.46 KB

patch

obsolete

>From 7995c9db8b8345d30e76a6915d1db9ff213cec83 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Wed, 23 Mar 2016 21:53:44 +0000
>Subject: [PATCH] Bug 15793 - UX of circulation patron search with long lists
> of returned borrowers
>
>Okay how about this:
>This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page.
>
>To test:
>1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a')
>2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page
>
>Sponsored-by: Catalyst IT
>---
> .../intranet-tmpl/prog/en/modules/circ/circulation.tt  |   16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 3bfc7fe..c1814ef 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -28,7 +28,6 @@
> <script type="text/javascript" src="[% themelang %]/js/pages/circulation.js"></script>
> <script type="text/javascript" src="[% themelang %]/js/checkouts.js"></script>
> <script type="text/javascript" src="[% themelang %]/js/holds.js"></script>
>-<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.fixFloat.js"></script>
> <script type="text/javascript">
> //<![CDATA[
> /* Set some variable needed in circulation.js */
>@@ -90,7 +89,9 @@ $(document).ready(function() {
>         }
>     });
> 
>-    $("#selecttoolbar").fixFloat();
>+    $(".clickable").click(function() {
>+        window.document.location = $(this).data('url');
>+    });
> 
>     [% IF !( CircAutoPrintQuickSlip == 'clear' ) %]
>         // listen submit to trigger qslip on empty checkout
>@@ -563,7 +564,7 @@ No patron matched <span class="ex">[% message %]</span>
> <form method="post" action="/cgi-bin/koha/circ/circulation.pl" id="mainform" name="mainform" autocomplete="off">
>     <input type="hidden" name="restoreduedatespec" />
> <fieldset id="circ_circulation_selectborrower" class="brief">
>-
>+ 
>     <legend>Patron selection</legend>
> 
> [% IF (forceallow) %]<input type="hidden" name="forceallow" value="1">[% END %]
>@@ -572,15 +573,9 @@ No patron matched <span class="ex">[% message %]</span>
>     <input type="hidden" name="duedatespec" value="[% duedatespec %]" />
>     <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" />
> 
>-<div id="selecttoolbar" class="btn-toolbar">
>-    <fieldset class="action"><button type="submit" class="btn btn-small"><i class="fa fa-check"></i> Select patron</button></fieldset>
>-</div>
>-
>-
>     <table id="table_borrowers">
>         <thead>
>             <tr>
>-                <th></th>
>                 <th>Name</th>
>                 <th>Cardnumber</th>
>                 <th>Category</th>
>@@ -590,8 +585,7 @@ No patron matched <span class="ex">[% message %]</span>
>         </thead>
>         <tbody>
>             [% FOREACH borrower IN borrowers %]
>-            <tr>
>-                <td><input type="radio" name="borrowernumber" value="[% borrower.borrowernumber %]" /></td>
>+            <tr class="clickable" data-url="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrower.borrowernumber %]">
>                 <td>[% borrower.surname %], [% borrower.firstname %]</td>
>                 <td>[% borrower.cardnumber %]</td>
>                 <td>[% borrower.categorycode %]</td>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15793: 47938 | 47940 | 47992 | 49457 | 49472 | 49520 | 49521 | 49611 | 49655 | 49656 | 49734