Bugzilla – Attachment 49496 Details for
Bug 15741
Incorrect rounding in total fines calculations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15741: Fix rounding in total fines calculations
Bug-15741-Fix-rounding-in-total-fines-calculations.patch (text/plain), 1.38 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-03-23 23:36:11 UTC
(
hide
)
Description:
Bug 15741: Fix rounding in total fines calculations
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-03-23 23:36:11 UTC
Size:
1.38 KB
patch
obsolete
>From 28b2fdf1fcee0e419e758fbd669b27219b2ea17d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 8 Mar 2016 11:58:24 +0000 >Subject: [PATCH] Bug 15741: Fix rounding in total fines calculations > >C4::Members::GetMemberAccountRecords wrongly casts float to integer >It's common to use sprintf in Perl to do this job. > >% perl -e 'print int(1000*64.60)."\n"'; >64599 >% perl -e 'print sprintf("%.0f", 1000*64.60)."\n"'; >64600 > >Test plan: >1) Create manual invoice for 64.60 (or 1.14, 1.36, ...) >2) Try to pay it using "Pay amount" or "Pay selected" buttons > >Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index ac64477..60af264 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -1062,7 +1062,7 @@ sub GetMemberAccountRecords { > } > $acctlines[$numlines] = $data; > $numlines++; >- $total += int(1000 * $data->{'amountoutstanding'}); # convert float to integer to avoid round-off errors >+ $total += sprintf "%.0f", 1000*$data->{amountoutstanding}; # convert float to integer to avoid round-off errors > } > $total /= 1000; > return ( $total, \@acctlines,$numlines); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15741
:
48776
|
49087
|
49484
|
49495
| 49496