Bugzilla – Attachment 49515 Details for
Bug 16007
Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16007: Simplify the DB entry
PASSED-QA-Bug-16007-Simplify-the-DB-entry.patch (text/plain), 2.39 KB, created by
Katrin Fischer
on 2016-03-24 06:46:49 UTC
(
hide
)
Description:
[PASSED QA] Bug 16007: Simplify the DB entry
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-24 06:46:49 UTC
Size:
2.39 KB
patch
obsolete
>From 4b5eeaef19d43ac55f2a79bcef8e5e0dfde3d4b6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 23 Mar 2016 16:59:02 +0000 >Subject: [PATCH] [PASSED QA] Bug 16007: Simplify the DB entry > >- No need to check if the table exists >- No need to check if the column exists, just remove the warning > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > ...ck_into_table_overduerules_transport_types.perl | 41 ++++------------------ > 1 file changed, 6 insertions(+), 35 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl b/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl >index 71a1dc2..dc8e211 100755 >--- a/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl >+++ b/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl >@@ -1,36 +1,7 @@ >-#!/usr/bin/perl >- >-use strict; >-use warnings; >- >-use C4::Context; >-use C4::Members; >- > my $dbh = C4::Context->dbh; >-my $sth = $dbh->prepare("SELECT * FROM overduerules_transport_types WHERE 0 = 1"); >-my $urv = $sth->execute(); >- >-my @data; >- >-if ( $sth->{NUM_OF_FIELDS} > 0 ) >-{ >- @data = @{$sth->{NAME}}; >- >- my @letternumber = grep { $_ eq 'letternumber' } @data; >- >- if ( ! @letternumber ) >- { >- my $urv = $dbh->do("ALTER TABLE overduerules_transport_types ADD COLUMN letternumber INT(1) NOT NULL DEFAULT 1 AFTER id"); >- print "Bug 16007: adding column 'letternumber' back into table 'overduerules_transport_types'\n"; >- } >- else >- { >- print "Bug 16007: your table 'overduerules_transport_types' already has a column 'letternumber'; nothing to do\n"; >- } >-} >-else >-{ >- # table overduerules_transport_types should exist by now, but let's >- # warn the user here just in case >- print "Bug 16007: [ERROR] your table 'overduerules_transport_types' does not exists ?!\n"; >-} >+my ($print_error) = $dbh->{PrintError}; >+$dbh->{RaiseError} = 0; >+$dbh->{PrintError} = 0; >+$dbh->do("ALTER TABLE overduerules_transport_types ADD COLUMN letternumber INT(1) NOT NULL DEFAULT 1 AFTER id"); >+$dbh->{PrintError} = $print_error; >+print "Bug 16007: Make sure overduerules_transport_types.letternumber exists\n"; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16007
:
49398
|
49401
|
49402
|
49403
|
49404
|
49455
|
49514
| 49515