Bugzilla – Attachment 49669 Details for
Bug 14257
Add show_extended_attributes to ILS-DI call GetPatronInfo
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14257: Follow-up - Add documentation, fix typo, fix test
Bug-14257-Follow-up---Add-documentation-fix-typo-f.patch (text/plain), 2.73 KB, created by
Katrin Fischer
on 2016-03-30 06:16:08 UTC
(
hide
)
Description:
Bug 14257: Follow-up - Add documentation, fix typo, fix test
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-30 06:16:08 UTC
Size:
2.73 KB
patch
obsolete
>From 4630354ae3bc6318cff0745921fff68c310315ad Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Wed, 30 Mar 2016 08:12:56 +0200 >Subject: [PATCH] Bug 14257: Follow-up - Add documentation, fix typo, fix test > >- t/db_dependent/ILSDI_Services.t was failing for me as I had > issues in my database, fixed with another delete line >- QA tools found a typo - comparision >- Added documentation of the new parameter to the ilsdi.pl page >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 2 ++ > t/db_dependent/ILSDI_Services.t | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt >index e6544cc..993af71 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt >@@ -514,6 +514,8 @@ > <dd>whether or not to return hold request information in the response</dd> > <dt><strong>show_loans</strong> (Optional, default 0)</dt> > <dd>whether or not to return loan information in the response</dd> >+ <dt><strong>show_attributes</strong> (Optional, default 0)</dt> >+ <dd>whether or not to return extended patron attributes information in the response</dd> > </dl> > <h4>Example call</h4> > <a href="ilsdi.pl?service=GetPatronInfo&patron_id=1&show_contact=0&show_loans=1"> >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index 73313bf..ee012e2 100644 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -100,6 +100,7 @@ $dbh->{RaiseError} = 0; > my $schema = Koha::Database->schema; > $schema->storage->txn_begin; > >+$schema->resultset( 'Issue' )->delete_all; > $schema->resultset( 'Borrower' )->delete_all; > $schema->resultset( 'BorrowerAttribute' )->delete_all; > $schema->resultset( 'BorrowerAttributeType' )->delete_all; >@@ -180,7 +181,7 @@ $schema->resultset( 'Branch' )->delete_all; > > my $reply = C4::ILSDI::Services::GetPatronInfo( $query ); > >- # Build a structure for comparision: >+ # Build a structure for comparison: > my $cmp = { > category_code => $attr_type->{'category_code'}, > class => $attr_type->{'class'}, >@@ -193,7 +194,7 @@ $schema->resultset( 'Branch' )->delete_all; > }; > > # Check results: >- is_deeply( $reply->{'attributes'}, [ $cmp ] ); >+ is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' ); > } > > # Cleanup >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14257
:
44656
|
44707
|
44864
|
44865
|
49579
|
49580
|
49581
|
49669
|
49696
|
49697
|
49698