Attachment 4969 Details for Bug 6479 – proposed patch (passed QA)

[patch] proposed patch (passed QA)

0001-Converts-all-the-serialseq-variables-to-UTF-8.patch (text/plain), 1.49 KB, created by Paul Poulain on 2011-08-11 16:10:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2011-08-11 16:10:32 UTC

Size: 1.49 KB

patch

obsolete

>From b33de43828362ca838161d007f5f81db6509f5fb Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9rick=20Capovilla?= <frederick.capovilla@sys-tech.net>
>Date: Tue, 7 Jun 2011 14:03:08 -0400
>Subject: [PATCH] Converts all the serialseq variables to UTF-8.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Corrects a problem when an UTF-8 character is used in the serial
>numbering formula. The encoding became incorrect when concatenating the
>number in the subscriptionhistory table.
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>To reproduce:
>- Create subscription with numbering pattern NÂ° {X}
>- Receive 2 or more issues
>- Check subscription summary page and manual history fields on the edit screen
>
>http://bugs.koha-community.org/show_bug.cgi?id=6479
>Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
>---
> serials/serials-edit.pl |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
>index db7620c..9ecd09f 100755
>--- a/serials/serials-edit.pl
>+++ b/serials/serials-edit.pl
>@@ -197,6 +197,11 @@ $template->param( subscriptions => \@subscriptionloop );
> 
> if ( $op and $op eq 'serialchangestatus' ) {
> 
>+    # Convert serialseqs to UTF-8 to prevent encoding problems
>+    foreach my $seq (@serialseqs) {
>+        utf8::decode($seq) unless utf8::is_utf8($seq);
>+    }
>+
>     my $newserial;
>     for ( my $i = 0 ; $i <= $#serialids ; $i++ ) {
>         my ($plan_date, $pub_date);
>-- 
>1.7.4.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 6479: 4424 | 4472 | 4473 | 4969