Attachment 49701 Details for Bug 13132 – [PASSED QA] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar

[patch] [PASSED QA] Bug 13132: Add confirm dialog for deleting reports from the reports toolbar

PASSED-QA-Bug-13132-Add-confirm-dialog-for-deletin.patch (text/plain), 2.10 KB, created by Katrin Fischer on 2016-03-30 22:23:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-03-30 22:23:46 UTC

Size: 2.10 KB

patch

obsolete

>From af7c4d8a5ae46f733e84e6f4fa1e76673d470af6 Mon Sep 17 00:00:00 2001
>From: Aleisha <aleishaamohia@hotmail.com>
>Date: Tue, 29 Mar 2016 23:27:23 +0000
>Subject: [PATCH] [PASSED QA] Bug 13132: Add confirm dialog for deleting
> reports from the reports toolbar
>
>To test:
>
>1) Go to Reports -> Use saved (or build a new one if you have none saved)
>2) Click on the Actions drop down and confirm that when you click Delete from here, a confirm message shows up. Click Cancel.
>3) Click Show in the drop down menu
>4) Click Delete in the Reports toolbar. Confirm you now get a confirm message. Clicking Cancel will cancel the delete, and clicking OK deletes the report and takes you to the saved reports page.
>
>Spponsored-by: Catalyst IT
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>After applying the patch I get a JavaScript popup confirmation when
>I click on the delete button, in the Show, Edit and Run views. Nice!
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index 373df25..eb1d266 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -27,7 +27,7 @@
> 
>         [% IF ( CAN_user_reports_create_reports ) %]
>             <div class="btn-group">
>-                <a class="confirmdelete btn btn-small" href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% id %]&phase=Delete%20Saved">
>+                <a class="confirmdelete btn btn-small" href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% id %]&phase=Delete%20Saved" onclick="return confirm(MSG_CONFIRM_DELETE);">
>                     <i class="fa fa-remove"></i> Delete
>                 </a>
>             </div>
>@@ -47,3 +47,7 @@
>         [% END %]
>     [% END %]
> </div>
>+
>+<script type="text/javascript">
>+var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this report? This cannot be undone.");
>+</script>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 13132: 33203 | 49659 | 49668 | 49701