Attachment 49702 Details for Bug 16174 – Bug 16174: Warning in tt_valid.t due to bug 15527

[patch] Bug 16174: Warning in tt_valid.t due to bug 15527

Bug-16174-Warning-in-ttvalidt-due-to-bug-15527.patch (text/plain), 1.26 KB, created by Mark Tompsett on 2016-03-30 23:07:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-03-30 23:07:17 UTC

Size: 1.26 KB

patch

obsolete

>From 5e80182195820accf58c893ea43cfbe09ffd6931 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
>Date: Wed, 30 Mar 2016 15:15:02 -0300
>Subject: [PATCH] Bug 16174: Warning in tt_valid.t due to bug 15527
>
>Bug 15527 introduced a new directory (xslt) on the top level OPAC templates
>directory. The tt_valid.t script should include that top level dir on the list
>of excluded dirs so it doesn't look for themes there.
>
>To test:
>- Run
>  $ prove xt/tt_valid.t
>=> FAIL: You get the following warning:
>Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory
> at xt/tt_valid.t line 8
>- Apply the patch
>- Run
>  $ prove xt/tt_valid.t
>=> SUCCESS: Tests pass and don't raise warnings.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> xt/tt_valid.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/xt/tt_valid.t b/xt/tt_valid.t
>index 4e5174b..7285019 100755
>--- a/xt/tt_valid.t
>+++ b/xt/tt_valid.t
>@@ -28,7 +28,7 @@ my @themes;
> # OPAC themes
> my $opac_dir  = 'koha-tmpl/opac-tmpl';
> opendir ( my $dh, $opac_dir ) or die "can't opendir $opac_dir: $!";
>-for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) {
>+for my $theme ( grep { not /^\.|lib|js|xslt/ } readdir($dh) ) {
>     push @themes, "$opac_dir/$theme/en";
> }
> close $dh;
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16174: 49692 | 49693 | 49702 | 49703 | 49737 | 49757 | 49777 | 49778 | 49779