Attachment 49764 Details for Bug 16184 – Bug 16184 - Report bor_issues_top shows incorrect number of rows

[patch] Bug 16184 - Report bor_issues_top shows incorrect number of rows

Bug-16184---Report-borissuestop-shows-incorrect-nu.patch (text/plain), 1.63 KB, created by Mark Tompsett on 2016-04-01 04:32:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-04-01 04:32:08 UTC

Size: 1.63 KB

patch

obsolete

>From fdb31ebb8e8f2119d01f1787cb400424a695d793 Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Fri, 1 Apr 2016 15:56:34 +1300
>Subject: [PATCH] Bug 16184 - Report bor_issues_top shows incorrect number of
> rows
>
>TEST PLAN
>---------
>1) Have at least 6 patrons with checkouts and some checkins.
>2) Reports -> Patrons with the most checkouts
>3) Click 'Submit' (default is 5)
>   -- more than 5 entries listed.
>4) Apply patch
>5) Refresh page
>   -- only 5 entries listed.
>6) Run koha qa test tools
>
>NOTE: While this works, I'd be much happier with a refactor
>      as it would also speed up the report. See comment #5.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> reports/bor_issues_top.pl | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl
>index e230a10..6cd5467 100755
>--- a/reports/bor_issues_top.pl
>+++ b/reports/bor_issues_top.pl
>@@ -160,6 +160,7 @@ sub calculate {
>     my $grantotal =0;
>     my $dbh = C4::Context->dbh;
> 
>+
> # Checking filters
>     my @loopfilter;
> 	my @cellmap = (
>@@ -362,6 +363,7 @@ sub calculate {
> 						} keys %patrons;
>     foreach my $id (@ranked_ids) {
>         my @loopcell;
>+
>         foreach my $key (@cols_in_order) {
> 			if($column){
> 		      push @loopcell, {
>@@ -381,8 +383,10 @@ sub calculate {
>                         'loopcell' => \@loopcell,
>                         'hilighted' => ($i%2),
>                     };
>+        # use a limit, if a limit is defined
>+        last if $i > $limit and $limit
>     }
>-	
>+
>     # the header of the table
>     $globalline{loopfilter}=\@loopfilter;
>     # the core of the table
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16184: 49760 | 49761 | 49764 | 49821