Attachment 49775 Details for Bug 16173 – Bug 16173: db_structure.t shouldn't have a fixed number of tests

[patch] Bug 16173: db_structure.t shouldn't have a fixed number of tests

Bug-16173-dbstructuret-shouldnt-have-a-fixed-numbe.patch (text/plain), 2.08 KB, created by Marcel de Rooy on 2016-04-01 08:16:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-04-01 08:16:02 UTC

Size: 2.08 KB

patch

obsolete

>From c553818551a9c015bde690f6f31ecd5be1c0befd Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
>Date: Wed, 30 Mar 2016 12:46:30 -0300
>Subject: [PATCH] Bug 16173: db_structure.t shouldn't have a fixed number of
> tests
>Content-Type: text/plain; charset=utf-8
>
>This patch makes db_structure.t more flexible regarding how many tests are run.
>This is important because it would fail on each db structure change, masking potential
>real problems.
>
>To test:
>- Run
>  $ prove t/db_dependent/db_structure.t
>=> FAIL: the number of tests ran doesn't match what is expected
>- Apply the patch
>- Run
>  $ prove t/db_dependent/db_structure.t
>=> SUCCESS: Tests count is not an issue [1]
>- Sign off
>
>[1] Right now the tests run successfuly, they might fail if a real bug is introduced
>on the DB structure, in the meantime.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/db_structure.t |   23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/db_structure.t b/t/db_dependent/db_structure.t
>index 41e5f2e..25f574a 100644
>--- a/t/db_dependent/db_structure.t
>+++ b/t/db_dependent/db_structure.t
>@@ -1,6 +1,23 @@
>+#!/usr/bin/perl
>+
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
> use Modern::Perl;
> 
>-use Test::More tests => 409;
>+use Test::More;
> use Koha::Database;
> 
> my @modules = (
>@@ -41,3 +58,7 @@ for my $modules ( @modules ) {
>         }
>     }
> }
>+
>+done_testing();
>+
>+1;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16173: 49689 | 49705 | 49775