Attachment 49784 Details for Bug 16185 – Bug 16185: t/db_dependent/Reports_Guided.t is failing

[patch] Bug 16185: t/db_dependent/Reports_Guided.t is failing

Bug-16185-tdbdependentReportsGuidedt-is-failing.patch (text/plain), 2.52 KB, created by Mark Tompsett on 2016-04-01 13:47:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-04-01 13:47:59 UTC

Size: 2.52 KB

patch

obsolete

>From cb891749b362dc5969e6d03a347724c2925a753b Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 1 Apr 2016 09:31:41 -0400
>Subject: [PATCH] Bug 16185: t/db_dependent/Reports_Guided.t is failing
>
>TEST PLAN
>---------
>1) prove t/db_dependent/Reports_Guided.t
>   -- fails
>   -- note the failure has a scalar function-like bracketing
>2) apply patch
>3) prove t/db_dependent/Reports_Guided.t
>   -- passes
>4) git diff origin/master
>   -- note all scalars have been changed to not have
>      function-like brackets which could be incorrectly
>      parsed.
>5) run koha qa test tools
>---
> t/db_dependent/Reports_Guided.t | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/t/db_dependent/Reports_Guided.t b/t/db_dependent/Reports_Guided.t
>index e48a8a9..4d89ebd 100755
>--- a/t/db_dependent/Reports_Guided.t
>+++ b/t/db_dependent/Reports_Guided.t
>@@ -43,7 +43,7 @@ $dbh->do(q|DELETE FROM saved_reports|);
> #Start tests
> 
> #Test save_report
>-my $count = scalar( @{ get_saved_reports() } );
>+my $count = scalar @{ get_saved_reports() };
> is( $count, 0, "There is no report" );
> 
> my @report_ids;
>@@ -67,10 +67,10 @@ like( $report_ids[0], '/^\d+$/', "Save_report returns an id for first" );
> like( $report_ids[1], '/^\d+$/', "Save_report returns an id for second" );
> like( $report_ids[2], '/^\d+$/', "Save_report returns an id for third" );
> 
>-is( scalar( @{ get_saved_reports() } ),
>+is( scalar @{ get_saved_reports() },
>     $count, "$count reports have been added" );
> 
>-is( scalar( @{ get_saved_reports( $report_ids[0] ) } ),
>+is( scalar @{ get_saved_reports( $report_ids[0] ) },
>     1, "filter takes report id" );
> 
> #Test delete_report
>@@ -79,17 +79,17 @@ is (delete_report(),undef, "Without id delete_report returns undef");
> is( delete_report( $report_ids[0] ), 1, "report 1 is deleted" );
> $count--;
> 
>-is( scalar( @{ get_saved_reports() } ), $count, "Report1 has been deleted" );
>+is( scalar @{ get_saved_reports() }, $count, "Report1 has been deleted" );
> 
> is( delete_report( $report_ids[1], $report_ids[2] ), 2, "report 2 and 3 are deleted" );
> $count -= 2;
> 
>-is( scalar( @{ get_saved_reports() } ),
>+is( scalar @{ get_saved_reports() },
>     $count, "Report2 and report3 have been deleted" );
> 
> my $sth = execute_query('SELECT COUNT(*) FROM systempreferences', 0, 10);
> my $results = $sth->fetchall_arrayref;
>-is(scalar(@$results), 1, 'running a query returned a result');
>+is(scalar @$results, 1, 'running a query returned a result');
> 
> my $version = C4::Context->preference('Version');
> $sth = execute_query(
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16185: 49784 | 49795