Bugzilla – Attachment 49796 Details for
Bug 16186
t/db_dependent/Circulation_Issuingrule.t is failing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing
Bug-16186-tdbdependentCirculationIssuingrulet-is-f.patch (text/plain), 3.30 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-04-01 15:11:52 UTC
(
hide
)
Description:
Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-04-01 15:11:52 UTC
Size:
3.30 KB
patch
obsolete
>From 349d694d76f010120b9c27c449f3a16f410d7f1a Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 1 Apr 2016 10:19:45 -0400 >Subject: [PATCH] Bug 16186: t/db_dependent/Circulation_Issuingrule.t is > failing > >TEST PLAN >--------- >1) prove t/db_dependent/Circulation_Issuingrule.t > -- fails >2) apply patch >3) prove t/db_dependent/Circulation_Issuingrule.t > -- pass >4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t > -- notice that bug 5876 and bug 9129 combined to cause this >5) run koha qa test tools > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >--- > t/db_dependent/Circulation_Issuingrule.t | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation_Issuingrule.t b/t/db_dependent/Circulation_Issuingrule.t >index 977cb8b..6e75672 100644 >--- a/t/db_dependent/Circulation_Issuingrule.t >+++ b/t/db_dependent/Circulation_Issuingrule.t >@@ -134,6 +134,7 @@ my $sampleissuingrule1 = { > maxsuspensiondays => 0, > onshelfholds => 0, > opacitemholds => 'N', >+ cap_fine_to_replacement_price => 0, > }; > my $sampleissuingrule2 = { > branchcode => $samplebranch2->{branchcode}, >@@ -164,6 +165,7 @@ my $sampleissuingrule2 = { > maxsuspensiondays => 0, > onshelfholds => 1, > opacitemholds => 'Y', >+ cap_fine_to_replacement_price => 0, > }; > my $sampleissuingrule3 = { > branchcode => $samplebranch1->{branchcode}, >@@ -194,6 +196,7 @@ my $sampleissuingrule3 = { > maxsuspensiondays => 0, > onshelfholds => 1, > opacitemholds => 'F', >+ cap_fine_to_replacement_price => 0, > }; > > $query = 'INSERT INTO issuingrules ( >@@ -222,8 +225,11 @@ $query = 'INSERT INTO issuingrules ( > reservecharge, > chargename, > restrictedtype, >- maxsuspensiondays >- ) VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)'; >+ maxsuspensiondays, >+ onshelfholds, >+ opacitemholds, >+ cap_fine_to_replacement_price >+ ) VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)'; > my $sth = $dbh->prepare($query); > $sth->execute( > $sampleissuingrule1->{branchcode}, >@@ -252,6 +258,9 @@ $sth->execute( > $sampleissuingrule1->{chargename}, > $sampleissuingrule1->{restrictedtype}, > $sampleissuingrule1->{maxsuspensiondays}, >+ $sampleissuingrule1->{onshelfholds}, >+ $sampleissuingrule1->{opacitemholds}, >+ $sampleissuingrule1->{cap_fine_to_replacement_price}, > ); > $sth->execute( > $sampleissuingrule2->{branchcode}, >@@ -280,6 +289,9 @@ $sth->execute( > $sampleissuingrule2->{chargename}, > $sampleissuingrule2->{restrictedtype}, > $sampleissuingrule2->{maxsuspensiondays}, >+ $sampleissuingrule2->{onshelfholds}, >+ $sampleissuingrule2->{opacitemholds}, >+ $sampleissuingrule2->{cap_fine_to_replacement_price}, > ); > $sth->execute( > $sampleissuingrule3->{branchcode}, >@@ -308,6 +320,9 @@ $sth->execute( > $sampleissuingrule3->{chargename}, > $sampleissuingrule3->{restrictedtype}, > $sampleissuingrule3->{maxsuspensiondays}, >+ $sampleissuingrule3->{onshelfholds}, >+ $sampleissuingrule3->{opacitemholds}, >+ $sampleissuingrule3->{cap_fine_to_replacement_price}, > ); > > is_deeply( >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16186
:
49794
| 49796