Attachment 49858 Details for Bug 16179 – Bug 16179: Do not crash if "rate me" is clicked and not rate selected

[patch] Bug 16179: Do not crash if "rate me" is clicked and not rate selected

Bug-16179-Do-not-crash-if-rate-me-is-clicked-and-n.patch (text/plain), 1.28 KB, created by Jonathan Druart on 2016-04-04 13:48:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-04-04 13:48:13 UTC

Size: 1.28 KB

patch

obsolete

>From afc3b77ff69aec750503ff377c86a15b0b63cedd Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 4 Apr 2016 14:45:48 +0100
>Subject: [PATCH] Bug 16179: Do not crash if "rate me" is clicked and not rate
> selected
>
>If JS is disabled and a user clicks on the "Rate me" button, Koha will
>crashes with:
>DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
>at /usr/share/koha/lib/C4/Ratings.pm line 208
>
>To avoid that, opac-ratings.pl will check if a rate has been selected.
>
>Test plan:
>Disable JS
>On a record detail page, click on the "Rate me" button
>---
> opac/opac-ratings.pl | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/opac/opac-ratings.pl b/opac/opac-ratings.pl
>index 2ad0cb0..23e73da 100755
>--- a/opac/opac-ratings.pl
>+++ b/opac/opac-ratings.pl
>@@ -45,6 +45,13 @@ my $rating_old_value = $query->param('rating_value');
> my $rating_value     = $query->param('rating');
> my $rating;
> 
>+# If JS is disabled and a user click on "Rate me" without selecting a rate
>+unless ( $biblionumber and $rating_value ) {
>+    print $query->redirect(
>+        "/cgi-bin/koha/opac-detail.pl?biblionumber=$biblionumber");
>+    exit;
>+}
>+
> if ( !$rating_old_value ) {
>     $rating = AddRating( $biblionumber, $loggedinuser, $rating_value );
> }
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16179: 49858 | 49936 | 50030 | 50222