Attachment 49985 Details for Bug 14598 – Bug 14598 [QA Followup] - Make unit test pass

[patch] Bug 14598 [QA Followup] - Make unit test pass

Bug-14598-QA-Followup---Make-unit-test-pass.patch (text/plain), 2.30 KB, created by Tomás Cohen Arazi (tcohen) on 2016-04-06 14:47:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-04-06 14:47:25 UTC

Size: 2.30 KB

patch

obsolete

>From f138fe9cedc6d3acefb092a218d1c0b710550320 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 12 Jan 2016 16:04:55 +0000
>Subject: [PATCH] Bug 14598 [QA Followup] - Make unit test pass
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
>---
> t/db_dependent/Circulation/Returns.t | 38 +++++++++++++++++++++---------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
>
>diff --git a/t/db_dependent/Circulation/Returns.t b/t/db_dependent/Circulation/Returns.t
>index 75cf63b..fd21d8f 100644
>--- a/t/db_dependent/Circulation/Returns.t
>+++ b/t/db_dependent/Circulation/Returns.t
>@@ -124,24 +124,30 @@ subtest "AddReturn logging on statistics table (item-level_itypes=1)" => sub {
>         MARC::Field->new($tagfield,'','', $tagsubfield => $blevel_itemtype )
>     );
>     my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '' );
>-    my $item_with_itemtype = $builder->build({
>-        source => 'Item',
>-        value  => {
>-            biblionumber  => $biblionumber,
>-            homebranch    => $branch,
>-            holdingbranch => $branch,
>-            itype         => $ilevel_itemtype
>+    my $item_with_itemtype = $builder->build(
>+        {
>+            source => 'Item',
>+            value  => {
>+                biblionumber     => $biblionumber,
>+                biblioitemnumber => $biblioitemnumber,
>+                homebranch       => $branch,
>+                holdingbranch    => $branch,
>+                itype            => $ilevel_itemtype
>+            }
>         }
>-    });
>-    my $item_without_itemtype = $builder->build({
>-        source => 'Item',
>-        value  => {
>-            biblionumber  => $biblionumber,
>-            homebranch    => $branch,
>-            holdingbranch => $branch,
>-            itype         => undef
>+    );
>+    my $item_without_itemtype = $builder->build(
>+        {
>+            source => 'Item',
>+            value  => {
>+                biblionumber     => $biblionumber,
>+                biblioitemnumber => $biblioitemnumber,
>+                homebranch       => $branch,
>+                holdingbranch    => $branch,
>+                itype            => undef
>+            }
>         }
>-    });
>+    );
> 
>     my $borrower = GetMember( borrowernumber => $borrowernumber );
>     AddIssue( $borrower, $item_with_itemtype->{ barcode } );
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 14598: 41198 | 41199 | 41200 | 41201 | 41202 | 41203 | 41204 | 41205 | 41383 | 41384 | 41385 | 41627 | 41628 | 41629 | 41637 | 42171 | 42177 | 44665 | 44666 | 44667 | 44668 | 45030 | 45047 | 45838 | 45843 | 45844 | 46546 | 46877 | 47108 | 47109 | 47110 | 47111 | 47112 | 47113 | 47114 | 47115 | 47116 | 49797 | 49798 | 49799 | 49800 | 49801 | 49802 | 49803 | 49804 | 49805 | 49807 | 49963 | 49964 | 49965 | 49966 | 49967 | 49968 | 49969 | 49970 | 49971 | 49972 | 49978 | 49979 | 49980 | 49981 | 49982 | 49983 | 49984 | 49985 | 49986 | 49987 | 49988 | 50018 | 56941 | 56942 | 56943 | 56944 | 56945 | 56946 | 56947 | 56948 | 56949 | 56950 | 56951 | 56952 | 56953 | 62539 | 62555 | 62682