Bugzilla – Attachment 50018 Details for
Bug 14598
itemtype is not set on statistics by C4::Circulation::AddReturn
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14598: Fix warning from effective_itemtype
Bug-14598-Fix-warning-from-effectiveitemtype.patch (text/plain), 1.58 KB, created by
Jonathan Druart
on 2016-04-07 11:04:04 UTC
(
hide
)
Description:
Bug 14598: Fix warning from effective_itemtype
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-04-07 11:04:04 UTC
Size:
1.58 KB
patch
obsolete
>From 7a79b47e719221b32fcc6cc0ef47bfce56cb15ba Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 7 Apr 2016 12:03:49 +0100 >Subject: [PATCH] Bug 14598: Fix warning from effective_itemtype > >--- > Koha/Schema/Result/Item.pm | 2 +- > t/db_dependent/Items.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Schema/Result/Item.pm b/Koha/Schema/Result/Item.pm >index 9b38812..3fb0b9e 100644 >--- a/Koha/Schema/Result/Item.pm >+++ b/Koha/Schema/Result/Item.pm >@@ -659,7 +659,7 @@ sub effective_itemtype { > if ( $pref && $self->itype() ) { > return $self->itype(); > } else { >- warn "item-level_itypes set but no itemtype set for item ($self->itemnumber)" >+ warn "item-level_itypes set but no itemtype set for item (".$self->itemnumber.")" > if $pref; > return $self->biblioitemnumber()->itemtype(); > } >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index e1a52a2..46bc5c5 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -281,7 +281,7 @@ subtest q{Test Koha::Database->schema()->resultset('Item')->itemtype()} => sub { > $item->update(); > my $effective_itemtype; > warning_is { $effective_itemtype = $item->effective_itemtype() } >- "item-level_itypes set but no itemtype set for item ($item->itemnumber)", >+ "item-level_itypes set but no itemtype set for item (".$item->itemnumber.")", > '->effective_itemtype() raises a warning when falling back to bib-level'; > > ok( defined $effective_itemtype && >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14598
:
41198
|
41199
|
41200
|
41201
|
41202
|
41203
|
41204
|
41205
|
41383
|
41384
|
41385
|
41627
|
41628
|
41629
|
41637
|
42171
|
42177
|
44665
|
44666
|
44667
|
44668
|
45030
|
45047
|
45838
|
45843
|
45844
|
46546
|
46877
|
47108
|
47109
|
47110
|
47111
|
47112
|
47113
|
47114
|
47115
|
47116
|
49797
|
49798
|
49799
|
49800
|
49801
|
49802
|
49803
|
49804
|
49805
|
49807
|
49963
|
49964
|
49965
|
49966
|
49967
|
49968
|
49969
|
49970
|
49971
|
49972
|
49978
|
49979
|
49980
|
49981
|
49982
|
49983
|
49984
|
49985
|
49986
|
49987
|
49988
|
50018
|
56941
|
56942
|
56943
|
56944
|
56945
|
56946
|
56947
|
56948
|
56949
|
56950
|
56951
|
56952
|
56953
|
62539
|
62555
|
62682