Attachment 5002 Details for Bug 6690 – Bug 6690: If multiple issues are received in serials-edit.pl, changing the status of any issue changes the date of the first issue.

[patch] Bug 6690: If multiple issues are received in serials-edit.pl, changing the status of any issue changes the date of the first issue.

Bug-6690-If-multiple-issues-are-received-in-serial.patch (text/plain), 3.56 KB, created by Katrin Fischer on 2011-08-14 19:44:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2011-08-14 19:44:11 UTC

Size: 3.56 KB

patch

obsolete

>From 5e9fa0d0885a8b68e430cf1f59c418c3463f1da4 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Fr=C3=A9d=C3=A9rick=20Capovilla?= <frederick.capovilla@sys-tech.net>
>Date: Sun, 14 Aug 2011 21:21:29 +0200
>Subject: [PATCH] Bug 6690: If multiple issues are received in serials-edit.pl, changing the status of any issue changes the date of the first issue.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset="utf-8"
>
>If multiple issues are in the list, changing the status of any issue in
>the table would always change the "Expected on" date of the first issue.
>Modified the javascript so the date is modified on the correct row.
>
>Reimplementation of Patch for 3.4.x
>Patch for 3.2.x from FrÃ©dÃ©rick Capovilla
>---
> .../prog/en/modules/serials/serials-edit.tt        |    9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>index 304c6ca..f82f791 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
>@@ -61,9 +61,8 @@ function HideItems(index,labelindex) {
> function setStatus(serialid){
>     $("#status"+serialid).val("2").attr("selected","selected");
> }
>-function changeDate(adate) {
>-    var elem = document.getElementById("expecteddate");
>-    elem.value = adate;
>+function changeDate(elem, adate) {
>+    $(elem).closest('tr').find('#expecteddate').val(adate);
> }
> function changeDate2(adate) {
>    var elem = document.getElementById("supexpecteddate");
>@@ -228,9 +227,9 @@ $(document).ready(function() {
>               <select name="status" size="1"  disabled="disabled">
>             [% ELSE %]
>               [% IF ( serialslis.serialsadditems ) %]
>-              <select name="status" size="1" id="status[% serialslis.serialid %]" onchange="if (this.value==2){unHideItems('items'+[% serialslis.subscriptionid %][% serialslis.serialid %],'label[% serialslis.subscriptionid %][% serialslis.serialid %]','[% serialslis.serialid %]'); changeDate('[% serialslis.arriveddate %]')} else if (this.value==7){changeDate('[% serialslis.arriveddate %]')} else { HideItems('items'+[% serialslis.subscriptionid %]+[% serialslis.serialid %],'label[% serialslis.subscriptionid %][% serialslis.serialid %]'); changeDate('[% serialslis.planneddate %]')}" >
>+              <select name="status" size="1" id="status[% serialslis.serialid %]" onchange="if (this.value==2){unHideItems('items'+[% serialslis.subscriptionid %][% serialslis.serialid %],'label[% serialslis.subscriptionid %][% serialslis.serialid %]','[% serialslis.serialid %]'); changeDate(this, '[% serialslis.arriveddate %]')} else if (this.value==7){changeDate(this, '[% serialslis.arriveddate %]')} else { HideItems('items'+[% serialslis.subscriptionid %]+[% serialslis.serialid %],'label[% serialslis.subscriptionid %][% serialslis.serialid %]'); changeDate(this, '[% serialslis.planneddate %]')}" >
>                [% ELSE %]
>-              <select name="status" size="1" id="status[% serialslis.serialid %]" onchange="if (this.value==2 || this.value==7){changeDate('[% serialslis.arriveddate %]')} else {changeDate('[% serialslis.planneddate %]')}" >
>+              <select name="status" size="1" id="status[% serialslis.serialid %]" onchange="if (this.value==2 || this.value==7){changeDate(this, '[% serialslis.arriveddate %]')} else {changeDate(this, '[% serialslis.planneddate %]')}" >
>                [% END %] 
>             [% END %]
>   [% IF ( serialslis.status1 ) %]
>-- 
>1.7.4.1

Actions: View | Diff | Splinter Review

Attachments on bug 6690: 4914 | 5002 | 5010