Attachment 50108 Details for Bug 16230 – Bug 16230 - Show tooltip with menu item when fund cannot be deleted

[patch] Bug 16230 - Show tooltip with menu item when fund cannot be deleted

Bug-16230---Show-tooltip-with-menu-item-when-fund-.patch (text/plain), 2.07 KB, created by Mark Tompsett on 2016-04-11 03:54:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2016-04-11 03:54:42 UTC

Size: 2.07 KB

patch

obsolete

>From 54a7be75c2a1fb5e66c038fd1ff04f6b75cc2dee Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 8 Apr 2016 13:33:01 -0400
>Subject: [PATCH] Bug 16230 - Show tooltip with menu item when fund cannot be
> deleted
>
>This patch enables Bootstrap to generate a tooltip for the fund deletion
>menu item when a fund cannot be deleted because it has children.
>
>Also changed: Enable translation of the associated error message.
>
>To test you must have at least one fund which has a child fund. Apply
>the patch and go to Administration -> Funds.
>
>- In the list of funds, find a fund which has children.
>- Click the "Actions" menu. The "Delete" item should be disabled.
>- Hovering over the "Delete" item should display a Bootstrap-style
>  tooltip with the explanation "This fund has children."
>- Clicking the "Delete" item should trigger an alert, "This fund has
>  children. It cannot be deleted."
>- Clicking "Delete" on funds without children should work correctly.
>
>NOTE: Before tooltip shows in Chrome, but not bootstrap styling.
>      After, bootstrap styled.
>      The use of _() will add the ability to translate the alert().
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>index fc22747..2679a57 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt
>@@ -228,9 +228,9 @@ var MSG_PARENT_BENEATH_BUDGET = "- " + _("New budget-parent is beneath budget")
>             $("#fundfilters").slideToggle(0);
>         });
> 
>-        $(".deletefund-disabled").on("click", function(e){
>+        $(".deletefund-disabled").tooltip().on("click", function(e){
>             e.preventDefault();
>-            alert("This fund has children. It cannot be deleted.");
>+            alert(_("This fund has children. It cannot be deleted."));
>         });
>     });
> //]]>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16230: 50088 | 50108 | 50109