Bugzilla – Attachment 50143 Details for
Bug 16246
Return all reserves columns in ILS-DI GetRecords response
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16246: Return all reserves columns in ILS-DI GetRecords response
Bug-16246-Return-all-reserves-columns-in-ILS-DI-Ge.patch (text/plain), 1.71 KB, created by
Julian Maurice
on 2016-04-12 12:25:20 UTC
(
hide
)
Description:
Bug 16246: Return all reserves columns in ILS-DI GetRecords response
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2016-04-12 12:25:20 UTC
Size:
1.71 KB
patch
obsolete
>From 69a5652558fb78bfe6f3b5727806ef4e0dbe9d97 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 11 Apr 2016 16:15:08 +0200 >Subject: [PATCH] Bug 16246: Return all reserves columns in ILS-DI GetRecords > response > >The list of reserves fields returned in ILS-DI GetRecords response is >arbitrary. Instead we should return all the fields available in reserves >table >--- > C4/ILSDI/Services.pm | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index b1db742..8a8166c 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -36,6 +36,8 @@ use DateTime; > use C4::Auth; > use C4::Members::Attributes qw(GetBorrowerAttributes); > >+use Koha::Holds; >+ > =head1 NAME > > C4::ILS-DI::Services - ILS-DI Services >@@ -209,7 +211,7 @@ sub GetRecords { > > # Get most of the needed data > my $biblioitemnumber = $biblioitem->{'biblioitemnumber'}; >- my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber }); >+ my $reserves = Koha::Holds->search({ biblionumber => $biblionumber })->unblessed; > my $issues = GetBiblioIssues($biblionumber); > my $items = GetItemsByBiblioitemnumber($biblioitemnumber); > >@@ -224,6 +226,11 @@ sub GetRecords { > $item->{'holdingbranchname'} = GetBranchName( $item->{'holdingbranch'} ); > } > >+ foreach my $reserve (@$reserves) { >+ # For backward compatibility >+ $reserve->{rtimestamp} = $reserve->{timestamp}; >+ } >+ > # Hashref building... > $biblioitem->{'items'}->{'item'} = $items; > $biblioitem->{'reserves'}->{'reserve'} = $reserves; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16246
:
50143
|
50144
|
56829
|
56830
|
61032
|
61033
|
61329
|
61330