Bugzilla – Attachment 50314 Details for
Bug 15009
Planning dropdown button in aqbudget can have empty line
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15009 - Planning dropdown button in aqbudget can have empty line
Bug-15009---Planning-dropdown-button-in-aqbudget-c.patch (text/plain), 1.59 KB, created by
Jonathan Druart
on 2016-04-18 09:40:41 UTC
(
hide
)
Description:
Bug 15009 - Planning dropdown button in aqbudget can have empty line
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-04-18 09:40:41 UTC
Size:
1.59 KB
patch
obsolete
>From 297e83539bc2e20eff61f9c249d462968958a731 Mon Sep 17 00:00:00 2001 >From: Blou <philippe.blouin@inlibro.com> >Date: Tue, 13 Oct 2015 16:12:49 -0400 >Subject: [PATCH] Bug 15009 - Planning dropdown button in aqbudget can have > empty line > >When displaying a budget, the Planning button in the admin toolbar displays > >Plan by months >Plan by libraries >Plan by item types >Plan by > >The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined. >This prevents returning an array with empty element(s) > >TEST: >1) Admin -> Budgets >2) Select a budget > a) you must have '' (empty) in your aqbudgets.sort1_authcat field. > b) edit the budget (direct DB or interface) to get that. >3) Click on Planning dropdown, see the "Plan by <nothing> " entry. >4) apply the patch, revalidate. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >No more empty option >No errors > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/Budgets.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Budgets.pm b/C4/Budgets.pm >index db936be..fd32010 100644 >--- a/C4/Budgets.pm >+++ b/C4/Budgets.pm >@@ -405,8 +405,8 @@ sub GetBudgetAuthCats { > $sth->execute($budget_period_id); > my %authcats; > while (my ($sort1_authcat,$sort2_authcat) = $sth->fetchrow) { >- $authcats{$sort1_authcat}=1; >- $authcats{$sort2_authcat}=1; >+ $authcats{$sort1_authcat}=1 if $sort1_authcat; >+ $authcats{$sort2_authcat}=1 if $sort2_authcat; > } > my @auth_cats_loop; > foreach (sort keys %authcats) { >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15009
:
43391
|
43392
|
44262
|
49601
|
50293
| 50314 |
50315
|
50316
|
50317