Attachment 50532 Details for Bug 16321 – Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade

[patch] Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade

Bug-16321---Show-all-details-checkbox-triggers-JS-.patch (text/plain), 1.51 KB, created by Owen Leonard on 2016-04-21 16:44:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-04-21 16:44:59 UTC

Size: 1.51 KB

patch

obsolete

>From b61a40679d81015a457de29600fe176b9ac54c86 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 21 Apr 2016 12:39:53 -0400
>Subject: [PATCH] Bug 16321 - 'Show all details' checkbox triggers JS error
> after jQuery upgrade
>Content-Type: text/plain; charset="utf-8"
>
>This patch fixes a problem with the 'Show all details' checkbox on the
>acquisitions basket page which prevented the checkbox from triggering
>the correct show/hide action on the table of orders.
>
>To test, apply the patch and go to Acquisitions.
>
>- Locate a vendor which has an open basket with multiple orders.
>- View the details of that basket.
>- Click the 'Show all details' checkbox above the table of orders.
>  - Checking the box should trigger the display of additional columns in
>    the table.
>  - Unchecking the box should hide them again.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 5aec704..6fe023d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -23,7 +23,7 @@
> 
>     $(document).ready(function() {
>         $("#show_all_details").click(function(){
>-            updateColumnsVisibility($(this+":checked").val());
>+            updateColumnsVisibility($(this).is(":checked"));
>         });
> 
>         $("#show_all_details").attr('checked', false);
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16321: 50532 | 50534 | 50710 | 50730