Attachment 50534 Details for Bug 16321 – Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade

[patch] Bug 16321 - 'Show all details' checkbox triggers JS error after jQuery upgrade

Bug-16321---Show-all-details-checkbox-triggers-JS-.patch (text/plain), 3.45 KB, created by Owen Leonard on 2016-04-21 17:35:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-04-21 17:35:30 UTC

Size: 3.45 KB

patch

obsolete

>From 2bd9281a181a041fff932dc673d43b845848ce33 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 21 Apr 2016 12:39:53 -0400
>Subject: [PATCH] Bug 16321 - 'Show all details' checkbox triggers JS error
> after jQuery upgrade
>Content-Type: text/plain; charset="utf-8"
>
>This patch fixes problems with show/hide actions on a few pages
>caused by some problematic jQuery syntax.
>
>To test, apply the patch and go to Acquisitions.
>
>Testing basket.tt:
>
>- Locate a vendor which has an open basket with multiple orders.
>- View the details of that basket.
>- Click the 'Show all details' checkbox above the table of orders.
>  - Checking the box should trigger the display of additional columns in
>    the table.
>  - Unchecking the box should hide them again.
>
>Testing invoice.tt:
>
>- Go to Acquisitions -> Invoices and perform an invoice search.
>- Click to view an invoice which includes one or more received records.
>- Click the 'Show all details' checkbox above the table of titles and
>  confirm that it fuctions as described above.
>
>Testing newordersubscription.tt:
>
>- Go to Acquisitions and locate a vendor which is linked to a
>  subscription
>- Create or add to a basket for that vendor.
>- Add an order using the 'From a subscription' option.
>- Perform a search for subscriptions.
>- In the table of subscriptions search results, checking or
>  unchecking the "Show only renewed" checkbox should work correctly.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt               | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt              | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 5aec704..6fe023d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -23,7 +23,7 @@
> 
>     $(document).ready(function() {
>         $("#show_all_details").click(function(){
>-            updateColumnsVisibility($(this+":checked").val());
>+            updateColumnsVisibility($(this).is(":checked"));
>         });
> 
>         $("#show_all_details").attr('checked', false);
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index 59e20f9..0708745 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -41,7 +41,7 @@
>         }));
> [% END %]
>         $("#show_all_details").click(function(){
>-            updateColumnsVisibility($(this+":checked").val());
>+            updateColumnsVisibility( $(this).is(":checked") );
>         });
> 
>         $("#show_all_details").attr('checked', false);
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
>index d6e65a0..77bef27 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
>@@ -27,7 +27,7 @@
>         } ) )
> 
>         $("#show_only_renewed").click(function(){
>-            updateRowsVisibility($(this+":checked").val());
>+            updateRowsVisibility( $(this).is(":checked") );
>         });
>         $("#show_only_renewed").attr('checked', false);
>         updateRowsVisibility(false);
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16321: 50532 | 50534 | 50710 | 50730