Attachment 50579 Details for Bug 16320 – Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm

[patch] Bug 16320: [QA Follow-up] Remove warnings from ILSDI/Services.pm

Bug-16320-QA-Follow-up-Remove-warnings-from-ILSDIS.patch (text/plain), 2.34 KB, created by Tomás Cohen Arazi (tcohen) on 2016-04-22 12:30:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-04-22 12:30:31 UTC

Size: 2.34 KB

patch

obsolete

>From 494a4812c0767dab1b647a82f6890fe282acb36c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 22 Apr 2016 13:49:21 +0200
>Subject: [PATCH] Bug 16320: [QA Follow-up] Remove warnings from
> ILSDI/Services.pm
>
>Removes:
>Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 373.
>Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 390.
>Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 399.
>Use of uninitialized value in string eq at /home/koha/kohaclone/C4/ILSDI/Services.pm line 423.
>
>Test plan:
>Run t/db_dependent/ILSDI_Services.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> C4/ILSDI/Services.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index b1db742..9f5a766 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -370,7 +370,7 @@ sub GetPatronInfo {
>     delete $borrower->{'password'};
> 
>     # Contact fields management
>-    if ( $cgi->param('show_contact') eq "0" ) {
>+    if ( defined $cgi->param('show_contact') && $cgi->param('show_contact') eq "0" ) {
> 
>         # Define contact fields
>         my @contactfields = (
>@@ -387,7 +387,7 @@ sub GetPatronInfo {
>     }
> 
>     # Fines management
>-    if ( $cgi->param('show_fines') eq "1" ) {
>+    if ( $cgi->param('show_fines') && $cgi->param('show_fines') eq "1" ) {
>         my @charges;
>         for ( my $i = 1 ; my @charge = getcharges( $borrowernumber, undef, $i ) ; $i++ ) {
>             push( @charges, @charge );
>@@ -396,7 +396,7 @@ sub GetPatronInfo {
>     }
> 
>     # Reserves management
>-    if ( $cgi->param('show_holds') eq "1" ) {
>+    if ( $cgi->param('show_holds') && $cgi->param('show_holds') eq "1" ) {
> 
>         # Get borrower's reserves
>         my @reserves = GetReservesFromBorrowernumber( $borrowernumber, undef );
>@@ -420,7 +420,7 @@ sub GetPatronInfo {
>     }
> 
>     # Issues management
>-    if ( $cgi->param('show_loans') eq "1" ) {
>+    if ( $cgi->param('show_loans') && $cgi->param('show_loans') eq "1" ) {
>         my $issues = GetPendingIssues($borrowernumber);
>         foreach my $issue ( @$issues ){
>             $issue->{'issuedate'} = $issue->{'issuedate'}->strftime('%Y-%m-%d %H:%M');
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 16320: 50531 | 50577 | 50578 | 50579 | 50587 | 50588 | 50873