Bugzilla – Attachment 50686 Details for
Bug 15414
Noisy warns when creating new layout for patron card creator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15414: Silencing warns triggered by creating a new layout in patron card creator
Bug-15414-Silencing-warns-triggered-by-creating-a-.patch (text/plain), 1.65 KB, created by
Aleisha Amohia
on 2016-04-25 23:10:57 UTC
(
hide
)
Description:
Bug 15414: Silencing warns triggered by creating a new layout in patron card creator
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-04-25 23:10:57 UTC
Size:
1.65 KB
patch
obsolete
>From 6f31fe77c29df4e99f7d13eedaff6eaa06714b7d Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 25 Apr 2016 23:08:49 +0000 >Subject: [PATCH] Bug 15414: Silencing warns triggered by creating a new > layout in patron card creator > >This patch assigns $field and $image values in the for loops > >To test: >1) Go to Tools -> Patron Card Creator -> New layout >2) Notice warns >3) Apply patch and refresh page >4) Notice warns are gone and page still works as expected > >Sponsored-by: Catalyst IT >--- > patroncards/edit-layout.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/patroncards/edit-layout.pl b/patroncards/edit-layout.pl >index 9e663d3..5d5d2df 100755 >--- a/patroncards/edit-layout.pl >+++ b/patroncards/edit-layout.pl >@@ -236,7 +236,7 @@ elsif ($op eq 'save') { > elsif ($op eq 'new') { # this is a new layout > $layout = C4::Patroncards::Layout->new(); > my @fields = (); >- for (my $field; $field < 4; $field++) { # limit 3 text fields >+ for (my $field = 0; $field < 4; $field++) { # limit 3 text fields > push @fields, ( > "field_$field" . "_font" => get_font_types(), > "field_$field" . "_text_alignment" => get_text_justification_types(), >@@ -244,7 +244,7 @@ elsif ($op eq 'new') { # this is a new layout > } > > my @images = (); >- for (my $image; $image < 3; $image++) { #limit 2 images >+ for (my $image = 0; $image < 3; $image++) { #limit 2 images > push @images, ( > "image_$image" . "_image_source" => $image_sources, > "image_$image" . "_image_name" => $image_names, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15414
:
50686
|
50689
|
50923