Attachment 50731 Details for Bug 16356 – [SIGNED-OFF] Bug 16356: Fix Error 500 when returning an item which itemtype is not in itemtypes table

[patch] [SIGNED-OFF] Bug 16356: Fix Error 500 when returning an item which itemtype is not in itemtypes table

SIGNED-OFF-Bug-16356-Fix-Error-500-when-returning-.patch (text/plain), 1.14 KB, created by Owen Leonard on 2016-04-26 16:38:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-04-26 16:38:26 UTC

Size: 1.14 KB

patch

obsolete

>From a4694278dc8e53eece2654ee47a840b2b623d06e Mon Sep 17 00:00:00 2001
>From: Sophie Meynieux <sophie.meynieux@biblibre.com>
>Date: Tue, 26 Apr 2016 18:04:45 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 16356: Fix Error 500 when returning an item
> which itemtype is not in itemtypes table
>Content-Type: text/plain; charset="utf-8"
>
>  Test plan :
>    * Find an item with itemtype (itype or bilbioitems.itemtype
>      depending on syspref) does not exist in itemtypes table
>    * If necessary, change itemtype of one of your item
>    * Check out this item
>    * Try to check it in, you've got a 500 Error and item is not
>      returned
>
>    With the patch
>    * Try to check your item in. Item is correctly returned
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> C4/ItemType.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/ItemType.pm b/C4/ItemType.pm
>index 209a77d..8efa81e 100644
>--- a/C4/ItemType.pm
>+++ b/C4/ItemType.pm
>@@ -116,6 +116,7 @@ sub get {
>     my $data = $dbh->selectrow_hashref(
>         "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype
>     );
>+    return unless defined $data;
>     return $class->new($data);
> }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16356: 50728 | 50731 | 50892