Bugzilla – Attachment 50734 Details for
Bug 16238
Upgrade jQuery in staff client: use .prop() instead of .attr()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 16238 [Follow-up] Upgrade jQuery in staff client: use .prop() instead of .attr()
SIGNED-OFF-Bug-16238-Follow-up-Upgrade-jQuery-in-s.patch (text/plain), 2.59 KB, created by
Bernardo Gonzalez Kriegel
on 2016-04-26 17:01:26 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 16238 [Follow-up] Upgrade jQuery in staff client: use .prop() instead of .attr()
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2016-04-26 17:01:26 UTC
Size:
2.59 KB
patch
obsolete
>From 2c7b50274ab2cd0d36ea5c74645c2f3a314691da Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 22 Apr 2016 09:01:26 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 16238 [Follow-up] Upgrade jQuery in staff > client: use .prop() instead of .attr() > >This patch corrects some tabs which should have been replaced with >spaces. > >To test, diff against the previous commit with the '-w' flag. There >should be no visible changes. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Space changes, no errors. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt >index 6ad6faf..51cbe11 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt >@@ -73,7 +73,7 @@ tr > td input,td input[type="submit"] { font-size: 85%; padding: 1px; } > }; > > var success_test_call = function() { >- $('#test_button').prop('disabled', false); >+ $('#test_button').prop('disabled', false); > $('#test_button').attr("value","test"); > }; > $(document).ready(function() { >@@ -100,7 +100,7 @@ tr > td input,td input[type="submit"] { font-size: 85%; padding: 1px; } > "success": count_approve // success_approve > }); > $(event.target).next(".rej").prop('disabled', false).attr("value",_("Reject")).css("color","#000"); >- $(event.target).attr( "value",_("Approved")).prop('disabled', true).css("color","#666"); >+ $(event.target).attr( "value",_("Approved")).prop('disabled', true).css("color","#666"); > return false; // cancel submit > } > if ($(event.target).is('.rej')) { >@@ -109,11 +109,11 @@ tr > td input,td input[type="submit"] { font-size: 85%; padding: 1px; } > "success": count_reject // success_reject > }); > $(event.target).prev(".ok").prop('disabled', false).attr("value",_("Approve")).css("color","#000"); >- $(event.target).attr( "value",_("Rejected")).prop('disabled', true).css("color","#666"); >+ $(event.target).attr( "value",_("Rejected")).prop('disabled', true).css("color","#666"); > return false; // cancel submit > } > if ($(event.target).is('#test_button')) { >- $(event.target).attr( "value",_("Testing...")).prop('disabled', true); >+ $(event.target).attr( "value",_("Testing...")).prop('disabled', true); > $.ajax({ > "data": {test: $('#test').attr("value")}, > "success": success_test_call // success_reject >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16238
:
50119
|
50177
|
50193
|
50194
|
50209
|
50210
|
50565
|
50566
|
50567
|
50568
|
50580
|
50581
|
50582
|
50583
|
50584
|
50734
|
50737
|
50738
|
50739
|
50740
|
50741