Attachment 50766 Details for Bug 15956 – [PASSED QA] Bug 15956: Remove warn from handle_patron_status

[patch] [PASSED QA] Bug 15956: Remove warn from handle_patron_status

PASSED-QA-Bug-15956-Remove-warn-from-handlepatrons.patch (text/plain), 1.43 KB, created by Katrin Fischer on 2016-04-26 22:07:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-04-26 22:07:56 UTC

Size: 1.43 KB

patch

obsolete

>From d96997b52cd858676aebd69c9d930ec4504c2397 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 2 Mar 2016 14:20:59 +0100
>Subject: [PATCH] [PASSED QA] Bug 15956: Remove warn from handle_patron_status
>
>Removes a warn and some commented warns.
>
>Test plan:
>Nothing to do here. Will be covered later by additional unit test.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/SIP/Sip/MsgType.pm | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index 7728ed4..360f7fe 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -467,7 +467,6 @@ sub build_patron_status {
> 
> sub handle_patron_status {
>     my ( $self, $server ) = @_;
>-    warn "handle_patron_status server: " . Dumper( \$server );
>     my $ils = $server->{ils};
>     my $patron;
>     my $resp    = (PATRON_STATUS_RESP);
>@@ -475,9 +474,6 @@ sub handle_patron_status {
>     my ( $lang, $date ) = @{ $self->{fixed_fields} };
>     my $fields = $self->{fields};
> 
>-    #warn Dumper($fields);
>-    #warn FID_INST_ID;
>-    #warn $fields->{(FID_INST_ID)};
>     $ils->check_inst_id( $fields->{ (FID_INST_ID) }, "handle_patron_status" );
>     $patron = $ils->find_patron( $fields->{ (FID_PATRON_ID) } );
>     $resp = build_patron_status( $patron, $lang, $fields, $server );
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15956: 48544 | 48545 | 48546 | 48547 | 48656 | 48663 | 48664 | 48665 | 48666 | 50239 | 50240 | 50241 | 50242 | 50765 | 50766 | 50767 | 50768