Attachment 50767 Details for Bug 15956 – [PASSED QA] Bug 15956: Move SIPILS.t to SIP/ILS.t

[patch] [PASSED QA] Bug 15956: Move SIPILS.t to SIP/ILS.t

PASSED-QA-Bug-15956-Move-SIPILSt-to-SIPILSt.patch (text/plain), 1.86 KB, created by Katrin Fischer on 2016-04-26 22:08:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-04-26 22:08:00 UTC

Size: 1.86 KB

patch

obsolete

>From 717ddad648ea910ad62bb4dc79d446058919e137 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 2 Mar 2016 14:33:27 +0100
>Subject: [PATCH] [PASSED QA] Bug 15956: Move SIPILS.t to SIP/ILS.t
>
>Move the file. Some trivial (cosmetic) edits: whitespace, comments.
>
>Test plan:
>Run SIP/ILS.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/db_dependent/{SIPILS.t => SIP/ILS.t} | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
> rename t/db_dependent/{SIPILS.t => SIP/ILS.t} (81%)
>
>diff --git a/t/db_dependent/SIPILS.t b/t/db_dependent/SIP/ILS.t
>similarity index 81%
>rename from t/db_dependent/SIPILS.t
>rename to t/db_dependent/SIP/ILS.t
>index 196c9b2..77eafa2 100755
>--- a/t/db_dependent/SIPILS.t
>+++ b/t/db_dependent/SIP/ILS.t
>@@ -1,5 +1,8 @@
> #!/usr/bin/perl
> 
>+# Tests for C4::SIP::ILS
>+# Please help to extend them!
>+
> # This file is part of Koha.
> #
> # Koha is free software; you can redistribute it and/or modify it
>@@ -26,16 +29,15 @@ BEGIN {
> my $class = 'C4::SIP::ILS';
> my $institution = { id => 'CPL', };
> 
>-my $ils = $class->new($institution);
>+my $ils = $class->new( $institution );
> 
> isa_ok( $ils, $class );
> 
> # Check all methods required for interface are there
>-# NB the mon_block routines are not here but Sip.pm thinks it can call them
>-my @methods = (
>-    qw( find_patron find_item checkout_ok checkin_ok offline_ok status_update_ok
>-      offline_ok checkout checkin end_patron_session pay_fee add_hold cancel_hold
>-      alter_hold renew renew_all)
>+my @methods = qw(
>+    find_patron find_item checkout_ok checkin_ok offline_ok status_update_ok
>+    offline_ok checkout checkin end_patron_session pay_fee add_hold cancel_hold
>+    alter_hold renew renew_all
> );
> 
> can_ok( $ils, @methods );
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 15956: 48544 | 48545 | 48546 | 48547 | 48656 | 48663 | 48664 | 48665 | 48666 | 50239 | 50240 | 50241 | 50242 | 50765 | 50766 | 50767 | 50768