Bugzilla – Attachment 50789 Details for
Bug 16337
Remove the use of "onclick" from the stage MARC records template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16337 - Remove the use of "onclick" from the stage MARC records template
PASSED-QA-Bug-16337---Remove-the-use-of-onclick-fr.patch (text/plain), 2.14 KB, created by
Katrin Fischer
on 2016-04-27 08:36:36 UTC
(
hide
)
Description:
[PASSED QA] Bug 16337 - Remove the use of "onclick" from the stage MARC records template
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-27 08:36:36 UTC
Size:
2.14 KB
patch
obsolete
>From 44a5c35705df95ec9ed9858063076df4faa436cc Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Sun, 24 Apr 2016 21:11:52 -0400 >Subject: [PATCH] [PASSED QA] Bug 16337 - Remove the use of "onclick" from the > stage MARC records template > >This patch reviseds the stage MARC records template, removing "onclick" >attributes from the markup and defining those events in the script. > >To test, apply the patch and go to Tools -> Stage MARC records for >import. > >- Select a MARC file for import. >- Click the "Upload file" button. Your upload should be processed > correctly. >- Select a MARC file for import. >- Click the "Upload file" button. >- Click the "Cancel" button before the file has been uploaded. The > upload should be cancelled. > >Signed-off-by: Aleisha <aleishaamohia@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >index e2b6425..223b4f9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt >@@ -23,6 +23,14 @@ $(document).ready(function(){ > $('#items').show(); > } > }); >+ $("#fileuploadbutton").on("click",function(e){ >+ e.preventDefault(); >+ StartUpload(); >+ }); >+ $("#fileuploadcancel").on("click",function(e){ >+ e.preventDefault(); >+ CancelUpload(); >+ }); > }); > function CheckForm(f) { > if ($("#fileToUpload").value == '') { >@@ -137,8 +145,8 @@ function cbUpload( status, fileid ) { > </div> </li> > </ol> > <fieldset class="action"> >- <button id="fileuploadbutton" onclick="StartUpload(); return false;">Upload file</button> >- <button id="fileuploadcancel" onclick="CancelUpload(); return false;">Cancel</button> >+ <button id="fileuploadbutton">Upload file</button> >+ <button id="fileuploadcancel">Cancel</button> > </fieldset> > </fieldset> > >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16337
:
50640
|
50688
| 50789