Attachment 50915 Details for Bug 16377 – [SIGNED-OFF] Bug 16377: Fix t/db_dependent/Members/Attributes.t

[patch] [SIGNED-OFF] Bug 16377: Fix t/db_dependent/Members/Attributes.t

SIGNED-OFF-Bug-16377-Fix-tdbdependentMembersAttrib.patch (text/plain), 4.88 KB, created by Bernardo Gonzalez Kriegel on 2016-04-28 13:24:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2016-04-28 13:24:53 UTC

Size: 4.88 KB

patch

obsolete

>From ba30611d52c1375c581c7446f8ddde1f18a7618d Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 28 Apr 2016 08:50:47 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 16377: Fix
> t/db_dependent/Members/Attributes.t
>
>This is a follow-up for bug 12267 fixing the test, still referring to
>password fields.
>
>Test plan:
>Run the test.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Test now pass
>No errors
>---
> t/db_dependent/Members/Attributes.t | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
>diff --git a/t/db_dependent/Members/Attributes.t b/t/db_dependent/Members/Attributes.t
>index 47a1417..134e5fa 100644
>--- a/t/db_dependent/Members/Attributes.t
>+++ b/t/db_dependent/Members/Attributes.t
>@@ -25,7 +25,7 @@ use C4::Members::AttributeTypes;
> use Koha::Database;
> use t::lib::TestBuilder;
> 
>-use Test::More tests => 57;
>+use Test::More tests => 53;
> 
> use t::lib::TestBuilder;
> 
>@@ -94,12 +94,10 @@ my $attributes = [
>     {
>         value => 'my attribute1',
>         code => $attribute_type1->code(),
>-        password => 'my password1',
>     },
>     {
>         value => 'my attribute2',
>         code => $attribute_type2->code(),
>-        password => 'my password2',
>     },
>     {
>         value => 'my attribute limited',
>@@ -124,11 +122,9 @@ is( @$borrower_attributes, 3, 'GetBorrowerAttributes returns the correct number
> is( $borrower_attributes->[0]->{code}, $attributes->[0]->{code}, 'SetBorrowerAttributes stores the correct code correctly' );
> is( $borrower_attributes->[0]->{description}, $attribute_type1->description(), 'SetBorrowerAttributes stores the field description correctly' );
> is( $borrower_attributes->[0]->{value}, $attributes->[0]->{value}, 'SetBorrowerAttributes stores the field value correctly' );
>-is( $borrower_attributes->[0]->{password}, $attributes->[0]->{password}, 'SetBorrowerAttributes stores the field password correctly' );
> is( $borrower_attributes->[1]->{code}, $attributes->[1]->{code}, 'SetBorrowerAttributes stores the field code correctly' );
> is( $borrower_attributes->[1]->{description}, $attribute_type2->description(), 'SetBorrowerAttributes stores the field description correctly' );
> is( $borrower_attributes->[1]->{value}, $attributes->[1]->{value}, 'SetBorrowerAttributes stores the field value correctly' );
>-is( $borrower_attributes->[1]->{password}, $attributes->[1]->{password}, 'SetBorrowerAttributes stores the field password correctly' );
> $borrower_attributes = C4::Members::Attributes::GetBorrowerAttributes($borrowernumber);
> is( @$borrower_attributes, 3, 'GetBorrowerAttributes returns the correct number of borrower attributes' );
> 
>@@ -136,12 +132,10 @@ $attributes = [
>     {
>         value => 'my attribute1',
>         code => $attribute_type1->code(),
>-        password => 'my password1',
>     },
>     {
>         value => 'my attribute2',
>         code => $attribute_type2->code(),
>-        password => 'my password2',
>     }
> ];
> C4::Members::Attributes::SetBorrowerAttributes($borrowernumber, $attributes);
>@@ -170,7 +164,6 @@ is( $attribute_value, $attributes->[1]->{value}, 'GetBorrowerAttributeValue retu
> my $attribute = {
>     attribute => 'my attribute3',
>     code => $attribute_type1->code(),
>-    password => 'my password3',
> };
> C4::Members::Attributes::UpdateBorrowerAttribute($borrowernumber, $attribute);
> $borrower_attributes = C4::Members::Attributes::GetBorrowerAttributes($borrowernumber);
>@@ -178,7 +171,6 @@ is( @$borrower_attributes, 3, 'UpdateBorrowerAttribute does not change the numbe
> is( $borrower_attributes->[0]->{code}, $attribute->{code}, 'UpdateBorrowerAttribute updates the field code correctly' );
> is( $borrower_attributes->[0]->{description}, $attribute_type1->description(), 'UpdateBorrowerAttribute updates the field description correctly' );
> is( $borrower_attributes->[0]->{value}, $attribute->{attribute}, 'UpdateBorrowerAttribute updates the field value correctly' );
>-is( $borrower_attributes->[0]->{password}, $attribute->{password}, 'UpdateBorrowerAttributes updates the field password correctly' );
> 
> 
> my $check_uniqueness = C4::Members::Attributes::CheckUniqueness();
>@@ -226,7 +218,6 @@ is( @$borrower_attributes, 2, 'DeleteBorrowerAttribute deletes a borrower attrib
> is( $borrower_attributes->[0]->{code}, $attributes->[1]->{code}, 'DeleteBorrowerAttribute deletes the correct entry');
> is( $borrower_attributes->[0]->{description}, $attribute_type2->description(), 'DeleteBorrowerAttribute deletes the correct entry');
> is( $borrower_attributes->[0]->{value}, $attributes->[1]->{value}, 'DeleteBorrowerAttribute deletes the correct entry');
>-is( $borrower_attributes->[0]->{password}, $attributes->[1]->{password}, 'DeleteBorrowerAttribute deletes the correct entry');
> 
> C4::Members::Attributes::DeleteBorrowerAttribute($borrowernumber, $attributes->[1]);
> $borrower_attributes = C4::Members::Attributes::GetBorrowerAttributes($borrowernumber);
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 16377: 50872 | 50915 | 50922