Bugzilla – Attachment 50947 Details for
Bug 15533
Allow patrons and librarians to select itemtype when placing hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15533 [QA Followup] - Itemtype limit missing from tables
PASSED-QA-Bug-15533-QA-Followup---Itemtype-limit-m.patch (text/plain), 2.77 KB, created by
Katrin Fischer
on 2016-04-28 19:03:13 UTC
(
hide
)
Description:
[PASSED QA] Bug 15533 [QA Followup] - Itemtype limit missing from tables
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-28 19:03:13 UTC
Size:
2.77 KB
patch
obsolete
>From 3ecc7eee692bcabf8987f901f9ca16a078817e20 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 28 Apr 2016 18:20:28 +0000 >Subject: [PATCH] [PASSED QA] Bug 15533 [QA Followup] - Itemtype limit missing > from tables > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/js/holds.js | 4 ++++ > reserve/request.pl | 2 +- > svc/holds | 7 +++++++ > 3 files changed, 12 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js >index c009ba7..959eed2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/holds.js >@@ -62,6 +62,10 @@ $(document).ready(function() { > data += "</p>"; > } > >+ if ( oObj.itemtype_limit ) { >+ data += _("<b> Next available %s item").format( oObj.itemtype_limit ); >+ } >+ > if ( oObj.barcode ) { > data += "<em>"; > if ( oObj.found == "W" ) { >diff --git a/reserve/request.pl b/reserve/request.pl >index 1e8ff18..1826e00 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -567,7 +567,7 @@ foreach my $biblionumber (@biblionumbers) { > $reserve{'suspend'} = $res->suspend(); > $reserve{'suspend_until'} = $res->suspend_until(); > $reserve{'reserve_id'} = $res->reserve_id(); >- $reserve{itemtype} = $res->{itemtype}; >+ $reserve{itemtype} = $res->itemtype(); > > if ( C4::Context->preference('IndependentBranches') && $flags->{'superlibrarian'} != 1 ) { > $reserve{'branchloop'} = [ Koha::Libraries->find( $res->branchcode() ) ]; >diff --git a/svc/holds b/svc/holds >index 9c90f8c..1db9338 100755 >--- a/svc/holds >+++ b/svc/holds >@@ -73,6 +73,12 @@ while ( my $h = $holds_rs->next() ) { > > my $biblionumber = $h->biblio()->biblionumber(); > >+ my $itemtype_limit; >+ if ( $h->itemtype ) { >+ my $itemtype = C4::Koha::getitemtypeinfo( $h->itemtype ); >+ $itemtype_limit = $itemtype->{translated_description}; >+ } >+ > my $hold = { > DT_RowId => $h->reserve_id(), > biblionumber => $biblionumber, >@@ -89,6 +95,7 @@ while ( my $h = $holds_rs->next() ) { > waiting_at => $h->branch()->branchname(), > waiting_here => $h->branch()->branchcode() eq $branch, > priority => $h->priority(), >+ itemtype_limit => $itemtype_limit, > subtitle => GetRecordValue( > 'subtitle', GetMarcBiblio($biblionumber), > GetFrameworkCode($biblionumber) >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15533
:
46462
|
48262
|
49227
|
49469
|
50016
|
50145
|
50926
|
50927
|
50928
|
50929
|
50931
|
50932
|
50933
|
50934
|
50937
|
50941
|
50942
|
50943
|
50944
|
50945
|
50946
| 50947 |
50948
|
50949