Attachment 51078 Details for Bug 16407 – Bug 16407: Simplify comments

[patch] Bug 16407: Simplify comments

Bug-16407-Simplify-comments.patch (text/plain), 1.57 KB, created by Jonathan Druart on 2016-05-02 09:48:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-05-02 09:48:10 UTC

Size: 1.57 KB

patch

obsolete

>From c055b9895634cba6eb780f95af0d8223956c5f2a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 2 May 2016 10:46:59 +0100
>Subject: [PATCH] Bug 16407: Simplify comments
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> t/db_dependent/Koha_borrower_modifications.t | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Koha_borrower_modifications.t b/t/db_dependent/Koha_borrower_modifications.t
>index 7763e5e..f98dfeb 100755
>--- a/t/db_dependent/Koha_borrower_modifications.t
>+++ b/t/db_dependent/Koha_borrower_modifications.t
>@@ -48,8 +48,7 @@ ok(
>     'Test that Verify() method fails for a bad token'
> );
> 
>-## Create new pending modification, but for an existing borrower
>-## But not a hardcoded borrowernumber of course (Bug 16407)
>+## Create new pending modification for a patron
> my $builder = t::lib::TestBuilder->new;
> my $borr1 = $builder->build({ source => 'Borrower' })->{borrowernumber};
> Koha::Patron::Modifications->new( borrowernumber => $borr1 )
>@@ -59,7 +58,7 @@ Koha::Patron::Modifications->new( borrowernumber => $borr1 )
> ok( Koha::Patron::Modifications->GetPendingModificationsCount() == 1,
>     'Test GetPendingModificationsCount()' );
> 
>-## Create new pending modification for another existing borrower
>+## Create new pending modification for another patron
> my $borr2 = $builder->build({ source => 'Borrower' })->{borrowernumber};
> Koha::Patron::Modifications->new( borrowernumber => $borr2 )
>   ->AddModifications( { surname => 'Smith', firstname => 'Sandy' } );
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16407: 51057 | 51060 | 51077 | 51078