Attachment 51125 Details for Bug 16428 – Bug 16428: Use the biblio framework to know if a field is mapped

[patch] Bug 16428: Use the biblio framework to know if a field is mapped

Bug-16428-Use-the-biblio-framework-to-know-if-a-fi.patch (text/plain), 1.41 KB, created by Jonathan Druart on 2016-05-03 10:08:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-05-03 10:08:16 UTC

Size: 1.41 KB

patch

obsolete

>From 1f020054385ca1d93abf45975ce8945118b2cc8b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 3 May 2016 11:03:52 +0100
>Subject: [PATCH] Bug 16428: Use the biblio framework to know if a field is
> mapped
>
>The subroutine _build_default_values_for_mod_marc takes the
>frameworkcode in parameter, but ModItemFromMarc did not pass it.
>It uses it to know if a field is mapped or not to a Koha field
>(C4::Koha::IsKohaFieldLinked).
>Consequently the default framework ("") was always used.
>
>This bug has been found working on bug 13074 and has been put on a
>separate bug report to ease the backport.
>
>Test plan:
>Without this change, the tests added by bug 16428 won't pass
>---
> C4/Items.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 6bb6e67..8ee4169 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -510,7 +510,7 @@ sub ModItemFromMarc {
>     my $localitemmarc = MARC::Record->new;
>     $localitemmarc->append_fields( $item_marc->field($itemtag) );
>     my $item = &TransformMarcToKoha( $localitemmarc, $frameworkcode, 'items' );
>-    my $default_values = _build_default_values_for_mod_marc();
>+    my $default_values = _build_default_values_for_mod_marc($frameworkcode);
>     foreach my $item_field ( keys %$default_values ) {
>         $item->{$item_field} = $default_values->{$item_field}
>           unless exists $item->{$item_field};
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16428: 51125 | 51230 | 51327 | 51430 | 51431