Bugzilla – Attachment 51158 Details for
Bug 16273
Prevent selfregistration from printing the borrower password and filling the logging form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16273: Add the ability not to display the login details for newly registered patrons
Bug-16273-Add-the-ability-not-to-display-the-login.patch (text/plain), 6.18 KB, created by
Nicolas Legrand
on 2016-05-03 15:24:04 UTC
(
hide
)
Description:
Bug 16273: Add the ability not to display the login details for newly registered patrons
Filename:
MIME Type:
Creator:
Nicolas Legrand
Created:
2016-05-03 15:24:04 UTC
Size:
6.18 KB
patch
obsolete
>From 9ceeef718f3b156c42aacb6c8a9135412b692ee7 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 23 Apr 2016 16:05:33 +0100 >Subject: [PATCH] Bug 16273: Add the ability not to display the login details > for newly registered patrons > >When a new patron registers, the confirmation page is displayed with >login details (login, password, cardnumber) and the login form is >prefilled. >In the case of public computer, for security reasons that should not >appear, patrons might forget to close the window. > >Test plan: >1/ Set PatronSelfRegistrationPrefillForm on >2/ Register a new patron >=> The login details should not be displayed and the login form should >not be prefilled. > >Sponsored-by: BULAC - http://www.bulac.fr/ >Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> >--- > .../en/modules/opac-registration-confirmation.tt | 49 ++++++++++++++-------- > 1 file changed, 31 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >index eb74172..70f2d19 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt >@@ -32,25 +32,28 @@ > <div id="registration-complete"> > <h1>Registration Complete!</h1> > >- <p>You have successfully registered your new account. To log in, use the following credentials:</p> >+ <p>You have successfully registered your new account.</p> >+ [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] >+ <p>To log in, use the following credentials:</p> > >- <p id="patron-userid-p"> >- <span id="patron-userid-label">Username:</span> >- <span id="patron-userid">[% borrower.userid %]</span> >- </p> >- <p id="patron-password-p"> >- <span id="patron-password-label">Password:</span> >- <span id="patron-password">[% password_cleartext %]<span> >- </p> >- >- [% IF borrower.cardnumber %] >- <p id="patron-cardnumber-p"> >- <span id="patron-cardnumber-label">Card number:</span> >- <span id="patron-cardnumber">[% borrower.cardnumber %]</span> >+ <p id="patron-userid-p"> >+ <span id="patron-userid-label">Username:</span> >+ <span id="patron-userid">[% borrower.userid %]</span> >+ </p> >+ <p id="patron-password-p"> >+ <span id="patron-password-label">Password:</span> >+ <span id="patron-password">[% password_cleartext %]<span> > </p> >- [% END %] > >- <p id="patron-instructions">For your convenience, the login box on this page has been pre-filled with this data. Please log in[% IF OpacPasswordChange %] and change your password[% END %].</p> >+ [% IF borrower.cardnumber %] >+ <p id="patron-cardnumber-p"> >+ <span id="patron-cardnumber-label">Card number:</span> >+ <span id="patron-cardnumber">[% borrower.cardnumber %]</span> >+ </p> >+ [% END %] >+ >+ <p id="patron-instructions">For your convenience, the login box on this page has been pre-filled with this data. Please log in[% IF OpacPasswordChange %] and change your password[% END %].</p> >+ [% END %] > > <div id="PatronSelfRegistrationAdditionalInstructions">[% PatronSelfRegistrationAdditionalInstructions %]</div> > </div> >@@ -67,8 +70,18 @@ > <input type="hidden" name="koha_login_context" value="opac" /> > <fieldset class="brief"> > <legend>Log in to your account:</legend> >- <label for="userid">Login:</label><input type="text" id="userid" size="10" name="userid" value="[% borrower.userid %]" /> >- <label for="password">Password:</label><input type="password" id="password" size="10" name="password" value="[% password_cleartext %]" /> >+ <label for="userid">Login:</label> >+ [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] >+ <input type="text" id="userid" size="10" name="userid" value="[% borrower.userid %]" /> >+ [% ELSE %] >+ <input type="text" id="userid" size="10" name="userid" value="" /> >+ [% END %] >+ <label for="password">Password:</label> >+ [% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %] >+ <input type="password" id="password" size="10" name="password" value="[% password_cleartext %]" /> >+ [% ELSE %] >+ <input type="password" id="password" size="10" name="password" value="" /> >+ [% END %] > <fieldset class="action"> > <input type="submit" value="Log in" class="btn" /> > </fieldset> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16273
:
50608
|
50609
|
51156
|
51157
|
51158
|
55663
|
55664