Bugzilla – Attachment 51167 Details for
Bug 16436
Allow action logs to be logged to the koha log file
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16436 - Allow action logs to be logged to the koha log file
Bug-16436---Allow-action-logs-to-be-logged-to-the-.patch (text/plain), 3.20 KB, created by
Kyle M Hall (khall)
on 2016-05-03 19:16:27 UTC
(
hide
)
Description:
Bug 16436 - Allow action logs to be logged to the koha log file
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-05-03 19:16:27 UTC
Size:
3.20 KB
patch
obsolete
>From ff3bed06120f9f8c1c7b3a572971d0de31fd7a8f Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 3 May 2016 18:58:57 +0000 >Subject: [PATCH] Bug 16436 - Allow action logs to be logged to the koha log > file > >Test Plan: >1) Ensure that your Koha::Logger configuration is in good working order >2) Apply this patch >3) Modify the first line of your log4perl.conf file from: > log4perl.logger.intranet = WARN, INTRANET > to > log4perl.logger.intranet = INFO, INTRANET >4) Change a system preference setting >5) Note the new line in your log file! >--- > C4/Log.pm | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > >diff --git a/C4/Log.pm b/C4/Log.pm >index de5f1d0..c7cc605 100644 >--- a/C4/Log.pm >+++ b/C4/Log.pm >@@ -24,8 +24,11 @@ package C4::Log; > use strict; > use warnings; > >+use JSON qw( to_json ); >+ > use C4::Context; > use Koha::DateUtils; >+use Koha::Logger; > > use vars qw(@ISA @EXPORT); > >@@ -77,6 +80,9 @@ sub logaction { > my $sth=$dbh->prepare("Insert into action_logs (timestamp,user,module,action,object,info) values (now(),?,?,?,?,?)"); > $sth->execute($usernumber,$modulename,$actionname,$objectnumber,$infos); > $sth->finish; >+ >+ my $logger = Koha::Logger->get( { interface => 'intranet', category => "ActionLogs.$modulename.$actionname" } ); >+ $logger->info( "ACTION LOG: " . to_json( { user => $usernumber, module => $modulename, action => $actionname, object => $objectnumber, info => $infos } ) ); > } > > =item cronlogaction >@@ -144,10 +150,10 @@ sub displaylog { > SELECT action_logs.timestamp, action_logs.action, action_logs.info, > borrowers.cardnumber, borrowers.surname, borrowers.firstname, borrowers.userid, > biblio.biblionumber, biblio.title, biblio.author >- FROM action_logs >- LEFT JOIN borrowers ON borrowers.borrowernumber=action_logs.user >+ FROM action_logs >+ LEFT JOIN borrowers ON borrowers.borrowernumber=action_logs.user > LEFT JOIN biblio ON action_logs.object=biblio.biblionumber >- WHERE action_logs.module = 'cataloguing' >+ WHERE action_logs.module = 'cataloguing' > |; > my %filtermap = (); > if ($modulename eq "catalogue" or $modulename eq "acqui") { >@@ -158,13 +164,13 @@ sub displaylog { > ); > } elsif ($modulename eq "members") { > $strsth=qq| >- SELECT action_logs.timestamp, action_logs.action, action_logs.info, >+ SELECT action_logs.timestamp, action_logs.action, action_logs.info, > borrowers.cardnumber, borrowers.surname, borrowers.firstname, borrowers.userid, > bor2.cardnumber, bor2.surname, bor2.firstname, bor2.userid >- FROM action_logs >- LEFT JOIN borrowers ON borrowers.borrowernumber=action_logs.user >+ FROM action_logs >+ LEFT JOIN borrowers ON borrowers.borrowernumber=action_logs.user > LEFT JOIN borrowers as bor2 ON action_logs.object=bor2.borrowernumber >- WHERE action_logs.module = 'members' >+ WHERE action_logs.module = 'members' > |; > %filtermap = ( > user => 'borrowers.surname', >@@ -204,7 +210,7 @@ sub displaylog { > > $logs = GetLogs($datefrom,$dateto,$user,\@modules,$action,$object,$info); > >-Return: >+Return: > C<$logs> is a ref to a hash which containts all columns from action_logs > > =cut >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16436
:
51165
|
51166
|
51167
|
51183
|
51938
|
53126
|
53876
|
53877