Attachment 51209 Details for Bug 16415 – Bug 16415 - Layout problem on staff client detail page if local cover images are enabled

[patch] Bug 16415 - Layout problem on staff client detail page if local cover images are enabled

Bug-16415---Layout-problem-on-staff-client-detail-.patch (text/plain), 1.85 KB, created by Jonathan Druart on 2016-05-04 16:42:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-05-04 16:42:37 UTC

Size: 1.85 KB

patch

obsolete

>From ea485dd19092431ed4866ae2e05143fcaace529b Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 2 May 2016 10:04:21 -0400
>Subject: [PATCH] Bug 16415 - Layout problem on staff client detail page if
> local cover images are enabled
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch fixes a layout problem which appears on the staff client
>bibliographic detail page if local covers are enabled but Amazon covers
>are not.
>
>To test, apply the patch and turn off AmazonCoverImages.
>
>- Enable the LocalCoverImages system preference and locate or create a
>  record which has a local cover image associated with it.
>- View the bibliographic detail page. The bibliographic details should
>  display in two columns, with text on the left and local cover image on
>  the right.
>- Test with AmazonCoverImages and LocalCoverImages enabled.
>- Test with AmazonCoverImages enabled and LocalCoverImages disabled.
>
>All combinations are OK.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index a1e4efb..d79398e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -341,7 +341,7 @@ function verify_images() {
>         <span class="Z3988" title="[% ocoins %]"></span>
>     [% END %]
> 
>-    [% IF ( AmazonCoverImages ) %]
>+    [% IF ( AmazonCoverImages  || LocalCoverImages ) %]
>         [% IF ( XSLTDetailsDisplay ) %]
>             <div class="yui-gc">
>             <div id="catalogue_detail_biblio" class="yui-u first">
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16415: 51102 | 51103 | 51109 | 51209