Attachment 51234 Details for Bug 13041 – Bug 13041 - Can't add user as manager of basket if name includes a single quote

[patch] Bug 13041 - Can't add user as manager of basket if name includes a single quote

Bug-13041---Cant-add-user-as-manager-of-basket-if-.patch (text/plain), 4.00 KB, created by Marc Véron on 2016-05-05 14:07:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-05-05 14:07:32 UTC

Size: 4.00 KB

patch

obsolete

>From 84adbde3f5d809acc3c6e395db6b48c3c8b372c3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 4 May 2016 09:34:46 -0400
>Subject: [PATCH] Bug 13041 - Can't add user as manager of basket if name
> includes a single quote
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>If you are trying to add a user as a manager of a basket in
>acquisitions, a JavaScript error will be triggered if that user has a
>single quote in their name (e.g. "O'Neil"). This patch corrects the
>issue by removing the "onclick" attribute and using the JS change made
>in Bug 16386.
>
>Also changed by this patch: Increased the size of the patron search
>popup and made a correction to some invalid HTML.
>
>To test you should have a patron whose name contains a single quote who
>is also a user with permission to manage acquisitions.
>
>- Apply the patch and go to Acquisitions.
>- Locate an open basket and view the details for that basket.
>- In the "Managed by" section, click the "Add user" button to trigger
>  the patron search popup.
>- Search for the patron described above and click the "Add" button.
>- In the parent window, the patron you chose should have been added to
>  the "Managed by" section.
>
>Tested on top of Bug 16383, behaves as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt              |    2 +-
> .../intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt    |    2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt      |    2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 2660a17..d2f49ea 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -126,7 +126,7 @@
>         window.open(
>             "/cgi-bin/koha/acqui/add_user_search.pl",
>             'UserSearchPopup',
>-            'width=740, height=450, scrollbars=yes, toolbar=no,'
>+            'width=840, height=500, scrollbars=yes, toolbar=no,'
>          );
>     }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
>index ef325f3..1bdd8ed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt
>@@ -18,7 +18,7 @@
>                     [%- IF selection_type == 'select' -%]
>                         "<a href=\"#\" style='cursor:pointer' onclick='select_user(\"[% data.borrowernumber %]\", [% To.json(data) | html %] );'>Select</a>"
>                     [%- ELSE -%]
>-                        "<a href=\"#\" style='cursor:pointer' onclick='add_user(\"[% data.borrowernumber %]\", \"[% data.firstname %] [% data.surname %]\");'>Select</a>"
>+                        "<a href=\"#\" data-borrowernumber=\"[% data.borrowernumber %]\" data-firstname=\"[% data.firstname %]\" data-surname=\"[% data.surname %]\" class=\"btn btn-mini add_user\"><i class=\"fa fa-plus\"></i> Add</a>"
>                     [%- END -%]
>             }[% UNLESS loop.last %],[% END %]
>         [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>index 41c83d8..99bb52f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
>@@ -199,7 +199,7 @@ function filterByFirstLetterSurname(letter) {
>                     <input type="submit" value="Search" />
>                 </fieldset>
>             </fieldset>
>-        <form>
>+        </form>
> 
>         [% IF patrons_with_acq_perm_only %]
>             <div class="hint">Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results</div>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13041: 51188 | 51234 | 51264 | 51266 | 51321