Attachment 51337 Details for Bug 16478 – Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts

[patch] Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts

Bug-16478-Translation-breaks-display-of-Checkout-h.patch (text/plain), 2.24 KB, created by Jonathan Druart on 2016-05-09 17:01:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-05-09 17:01:47 UTC

Size: 2.24 KB

patch

obsolete

>From 140c6490a0b3e48ef7009e69b173f285c9aae9c1 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Mon, 9 May 2016 18:30:27 +0200
>Subject: [PATCH] Bug 16478: Translation breaks display of Checkout history in
> tab Checks / On-site-checkouts
>
>To test:
>- Make sure that syspref OnsiteCheckouts is enabled
>- Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled
>- Go to 'your reading history' (in English)
>- Display all three tabs
>- Apply patch
>- Reload page, display oll three tabs again, there should be no difference
>- Examine source code changes to verify that the words 'checkout' and 'onsite' no longer
>  will be exposed to translation.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>index 2eb7ead..19bbe49 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>@@ -80,11 +80,10 @@
>                                             [% FOREACH issue IN READING_RECORD %]
>                                                 <tr>
>                                                     <td style="display:none;">
>-                                                      [% IF issue.onsite_checkout %]
>-                                                        onsite
>-                                                      [% ELSE %]
>-                                                        checkout
>+                                                      [% IF issue.onsite_checkout %][% issuetype = 'onsite' %]
>+                                                      [% ELSE %][% issuetype = 'checkout' %]
>                                                       [% END %]
>+                                                      [% issuetype %]
>                                                     </td>
>                                                 <td>
>                                                     [% IF  OPACAmazonCoverImages %]
>-- 
>2.7.0

Actions: View | Diff | Splinter Review

Attachments on bug 16478: 51334 | 51336 | 51337 | 51338 | 51342 | 51602 | 51603