Bugzilla – Attachment 51352 Details for
Bug 16481
Report menu has unexpected issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 16481 - Report menu has unexpected issues
SIGNED-OFF-Bug-16481---Report-menu-has-unexpected-.patch (text/plain), 1.94 KB, created by
Aleisha Amohia
on 2016-05-09 22:12:38 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 16481 - Report menu has unexpected issues
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-05-09 22:12:38 UTC
Size:
1.94 KB
patch
obsolete
>From 7ecb1b1c298469b042fec0f9c0f943e6a3a0ebd3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 9 May 2016 14:23:34 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 16481 - Report menu has unexpected issues > >This patch corrects a problem with the reports toolbar include file >which can cause a problem with the "duplicate" button. The duplicate >button passes the entire report SQL as a URL parameter, but the template >variable was not escaped as a URL variable. > >This patch also adds the "uri" filter to the report name and notes >fields just to be safe. > >To reproduce the bug, create a new SQL report using the SQL in the bug >report. When you run the report you should see a broken "Duplicate" >button. > >Apply the patch and run the report again. The duplicate button should >look correct and work correctly. > >Signed-off-by: Aleisha <aleishaamohia@hotmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >index fef1166..198a364 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc >@@ -19,7 +19,7 @@ > </div> > [% END %] > <div class="btn-group"> >- <a class="btn btn-small" title="Duplicate this saved report" href="/cgi-bin/koha/reports/guided_reports.pl?phase=Create report from SQL&sql=[% sql %]&reportname=[% reportname %]&notes=[% notes %]"> >+ <a class="btn btn-small" title="Duplicate this saved report" href="/cgi-bin/koha/reports/guided_reports.pl?phase=Create report from SQL&sql=[% sql |uri %]&reportname=[% reportname |uri %]&notes=[% notes |uri %]"> > <i class="fa fa-copy"></i> Duplicate > </a> > </div> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16481
:
51340
|
51341
|
51343
|
51352
|
51404