Attachment 51421 Details for Bug 13871 – Bug 13871: [QA Follow-up] Fix small regression on AF with branchcode in Patron Info request

[patch] Bug 13871: [QA Follow-up] Fix small regression on AF with branchcode in Patron Info request

Bug-13871-QA-Follow-up-Fix-small-regression-on-AF-.patch (text/plain), 1.30 KB, created by Marcel de Rooy on 2016-05-11 12:49:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-05-11 12:49:28 UTC

Size: 1.30 KB

patch

obsolete

>From 2c8a381f6dd44fb5ce6b8354c688d58c190182a3 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 11 May 2016 14:42:33 +0200
>Subject: [PATCH] Bug 13871: [QA Follow-up] Fix small regression on AF with
> branchcode in Patron Info request
>Content-Type: text/plain; charset=utf-8
>
>If you enable send_patron_home_library_in_af in your sip account, you
>want a separate AF field for the home branch.
>
>Test plan:
>Send a 63 (Patron Info) and verify that you have an extra AF.
>---
> C4/SIP/Sip/MsgType.pm |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index 360f7fe..787449b 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -1001,10 +1001,10 @@ sub handle_patron_info {
>         if( defined( $patron_pwd ) && !$password_rc ) {
>             $msg .= ' -- ' . INVALID_PW;
>         }
>+        $resp .= maybe_add( FID_SCREEN_MSG, $msg, $server );
>         if ( $server->{account}->{send_patron_home_library_in_af} ) {
>-            $msg .= ' -- ' . $patron->{branchcode};
>+            $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server);
>         }
>-        $resp .= maybe_add( FID_SCREEN_MSG, $msg, $server );
>         $resp .= maybe_add( FID_PRINT_LINE, $patron->print_line );
>     } else {
> 
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 13871: 37539 | 37543 | 38451 | 38452 | 38453 | 38454 | 38455 | 45645 | 45646 | 45647 | 45648 | 45649 | 48386 | 48387 | 48388 | 48389 | 48390 | 48391 | 48392 | 48393 | 48667 | 48668 | 48669 | 48670 | 48671 | 48672 | 51421 | 51422