Attachment 51431 Details for Bug 16428 – Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in _build_default_values_for_mod_marc

[patch] Bug 16428: [QA Follow-up] Useless call to GetMarcStructure in _build_default_values_for_mod_marc

Bug-16428-QA-Follow-up-Useless-call-to-GetMarcStru.patch (text/plain), 1.05 KB, created by Marcel de Rooy on 2016-05-11 13:54:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-05-11 13:54:26 UTC

Size: 1.05 KB

patch

obsolete

>From 4c9709e4255b190757a8b1394c9e6a79e07aab8c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 11 May 2016 15:47:46 +0200
>Subject: [PATCH] Bug 16428: [QA Follow-up] Useless call to GetMarcStructure
> in _build_default_values_for_mod_marc
>Content-Type: text/plain; charset=utf-8
>
>The routine calls GetMarcStructure and does not use its return value
>after all.
>
>Test plan:
>Run t/db_dependent/Items.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/Items.pm |    1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 8ee4169..651e590 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -455,7 +455,6 @@ sub _build_default_values_for_mod_marc {
>     my ($frameworkcode) = @_;
>     return $default_values_for_mod_from_marc{$frameworkcode}
>       if exists $default_values_for_mod_from_marc{$frameworkcode};
>-    my $marc_structure = C4::Biblio::GetMarcStructure( 1, $frameworkcode );
>     my $default_values = {
>         barcode                  => undef,
>         booksellerid             => undef,
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16428: 51125 | 51230 | 51327 | 51430 | 51431