Bugzilla – Attachment 51438 Details for
Bug 16501
Remove some unneeded warns in Upload.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16501: Remove some unneeded warns in Upload.t
Bug-16501-Remove-some-unneeded-warns-in-Uploadt.patch (text/plain), 1.27 KB, created by
Marcel de Rooy
on 2016-05-11 14:26:03 UTC
(
hide
)
Description:
Bug 16501: Remove some unneeded warns in Upload.t
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-05-11 14:26:03 UTC
Size:
1.27 KB
patch
obsolete
>From 18285c5b8d79aa037def01a5782ecdab1babaabe Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 11 May 2016 16:17:47 +0200 >Subject: [PATCH] Bug 16501: Remove some unneeded warns in Upload.t >Content-Type: text/plain; charset=utf-8 > >At some point I saw some gain in warning about a missing config line. >But these warns are actually not needed here. >Removing them here. > >Test plan: >Run t/db_dependent/Upload.t while having upload_path in your koha-conf and >also without it. >--- > t/db_dependent/Upload.t | 9 --------- > 1 file changed, 9 deletions(-) > >diff --git a/t/db_dependent/Upload.t b/t/db_dependent/Upload.t >index f6b46fc..1449c98 100644 >--- a/t/db_dependent/Upload.t >+++ b/t/db_dependent/Upload.t >@@ -37,15 +37,6 @@ our $uploads = [ > ], > ]; > >-# Before we mock upload_path, we are checking the real folder >-# This may help identifying upload problems >-my $realdir = C4::Context->config('upload_path'); >-if( !$realdir ) { >- warn "WARNING: You do not have upload_path in koha-conf.xml"; >-} elsif( !-w $realdir ) { >- warn "WARNING: You do not have write permissions in $realdir"; >-} >- > # Redirect upload dir structure and mock File::Spec and CGI > my $tempdir = tempdir( CLEANUP => 1 ); > t::lib::Mocks::mock_config('upload_path', $tempdir); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16501
:
51438
|
51448
|
51487