Bugzilla – Attachment 51490 Details for
Bug 1859
Notice fields: can't select multiple fields at once
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 1859: Do not display <<>> if an entry without value is selected
Bug-1859-Do-not-display--if-an-entry-without-value.patch (text/plain), 1.27 KB, created by
Jonathan Druart
on 2016-05-13 21:05:04 UTC
(
hide
)
Description:
Bug 1859: Do not display <<>> if an entry without value is selected
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-05-13 21:05:04 UTC
Size:
1.27 KB
patch
obsolete
>From f0dbfbcb9b7905e682df677dfe8c980840fac09e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 13 May 2016 22:03:08 +0100 >Subject: [PATCH] Bug 1859: Do not display <<>> if an entry without value is > selected > >For instance there are ---TABLES--- to delimite fields' tables, if >selected we do not want to add "<<>>" to the letter. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index 8ed7a52..2af7a0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -134,7 +134,7 @@ $(document).ready(function() { > > if($(myListBox).find('option').length > 0) { > $(myListBox).find('option').each( function (){ >- if ( $(this).attr('selected') ) { >+ if ( $(this).attr('selected') && $(this).val().length > 0 ) { > $(myQuery).insertAtCaret("<<" + $(this).val() + ">>"); > } > }); >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1859
:
51464
|
51465
|
51489
| 51490