Attachment 51491 Details for Bug 16517 – [SIGNED-OFF] Bug 16517: Do not crash when creating a list with an existing name

[patch] [SIGNED-OFF] Bug 16517: Do not crash when creating a list with an existing name

SIGNED-OFF-Bug-16517-Do-not-crash-when-creating-a-.patch (text/plain), 1.41 KB, created by Owen Leonard on 2016-05-13 21:47:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2016-05-13 21:47:18 UTC

Size: 1.41 KB

patch

obsolete

>From 0f2ae8708a5db8860d1db32dd5c2a1383be9e103 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 13 May 2016 20:21:12 +0100
>Subject: [PATCH] [SIGNED-OFF] Bug 16517: Do not crash when creating a list
> with an existing name
>Content-Type: text/plain; charset="utf-8"
>
>A typo has been made during a merge conflict when rebasing bug 16517.
>
>it should be
>  eval { Koha::Object->new->store; };
>instead of
>  eval { Koha::Object->new; }->store;
>
>Test plan:
>From the result list (intranet side), check some entries and add them to
>a new list
>Use an existing list's name
>=> Without this patch you will get a server error (exception 'Duplicate shelf
>object' raised by Koha::Virtualshelf->new->store)
>=> With this patch you must get a friendly error message
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> virtualshelves/addbybiblionumber.pl |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl
>index 790904f..71270b7 100755
>--- a/virtualshelves/addbybiblionumber.pl
>+++ b/virtualshelves/addbybiblionumber.pl
>@@ -132,8 +132,8 @@ sub HandleNewVirtualShelf {
>                 sortfield => $sortfield,
>                 owner => $loggedinuser,
>             }
>-        );
>-    }->store;
>+        )->store;
>+    };
>     if ( $@ or not $shelf ) {
>         $authorized = 0;
>         $errcode    = 1;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 16517: 51482 | 51491 | 51604