Attachment 51513 Details for Bug 16518 – [SIGNED-OFF] Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl

[patch] [SIGNED-OFF] Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl

Bug-16518-Fix-Plack-variable-scoping-problem-in-op.patch (text/plain), 1.54 KB, created by Srdjan Jankovic on 2016-05-16 06:18:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2016-05-16 06:18:56 UTC

Size: 1.54 KB

patch

obsolete

>From ca8a284000df593b54041db146d06c5c67df0c73 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 13 May 2016 20:46:42 +0100
>Subject: [PATCH] Bug 16518: Fix Plack variable scoping problem in
> opac-addbybiblionumber.pl
>
>The script opac/opac-addbybiblionumber.pl is not plack safe because the
>variable @biblios is declared with our and is not assigned to an empty
>array (so not reset).
>
>The issue:
>When trying to add items to a list (virtualshelf), the biblionumbers are
>added to the @biblios variable and the list is not reset between each
>run.
>
>Test plan:
>Check from records from the result list and add them
>to a list.
>Cancel or save and re-add them (or others) to a list (same or
>different).
>=> Without this patch, the list of records will never stop growing, the
>previous items added are still listed when adding new ones.
>=> With this patch, the behavior is the one expected.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> opac/opac-addbybiblionumber.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-addbybiblionumber.pl b/opac/opac-addbybiblionumber.pl
>index eec38bd..a5decf7 100755
>--- a/opac/opac-addbybiblionumber.pl
>+++ b/opac/opac-addbybiblionumber.pl
>@@ -38,7 +38,7 @@ our $newvirtualshelf	= $query->param('newvirtualshelf');
> our $category     	= $query->param('category');
> our $authorized          = 1;
> our $errcode		= 0;
>-our @biblios;
>+our @biblios = ();
> 
> # if virtualshelves is disabled, leave immediately
> if ( ! C4::Context->preference('virtualshelves') ) {
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 16518: 51483 | 51513 | 52055